On 17/08/2021 10:10, Jan Beulich wrote: > On 12.08.2021 19:03, Andrew Cooper wrote: >> I'm not a massive fan of the large ifdef area. The logic could be rearranged >> to use IS_ENABLED(CONFIG_XEN_SHSTK) by indenting most of the function, but I >> can't see any way to drop the goto's, and this is certainly the >> least-invasive >> diff. > So perhaps the build failure I've just run into (also apparently spotted > by osstest) suggests to actually do so? The alternative would seem to be > to widen the #ifdef in get_shstk_bottom() to cover the function as a > whole ...
Let me see how the options look... ~Andrew
