On 27/07/2021 19:47, Jane Malalane wrote:
> diff --git a/xen/lib/strcmp.c b/xen/lib/strcmp.c
> index 465f1c4191..f85c1e8741 100644
> --- a/xen/lib/strcmp.c
> +++ b/xen/lib/strcmp.c
> @@ -11,14 +11,16 @@
> */
> int (strcmp)(const char *cs, const char *ct)
> {
> - register signed char __res;
> + unsigned char *csu = (unsigned char *)cs;
> + unsigned char *ctu = (unsigned char *)ct;
So there was actually one final thing, but it is holiday season, hence
the lack of replies from others.
We should not be casting away const-ness on the pointers, because that
is undefined behaviour and compilers are starting to warn about it.
Therefore, we want something like:
const unsigned char *csu = (const unsigned char *)cs;
~Andrew
