On 13.07.2021 03:59, Bobby Eshleman wrote: > The function domain_pause_for_debugger() is conditionally compiled if > CONFIG_CRASH_DEBUG=y. Instead of placing an extra #ifdef inside > domain.c, this commit moves domain_pause_for_debugger() into > x86/debugger.c which is only built by Kbuild given CONFIG_CRASH_DEBUG=y. > > Signed-off-by: Bobby Eshleman <[email protected]>
Acked-by: Jan Beulich <[email protected]> preferably with ... > --- a/xen/arch/x86/debugger.c > +++ b/xen/arch/x86/debugger.c > @@ -15,6 +15,18 @@ > #include <xen/event.h> > #include <xen/sched.h> > > +void domain_pause_for_debugger(void) > +{ > + struct vcpu *curr = current; ... "const" added here while you're moving this anyway. Jan
