On 02.07.2021 21:03, Andrew Cooper wrote:
> The code has gone through many refactors, but the first refactor was the one
> which broke it by inverting the check with respect to checkpointed streams.
>
> Fixes: 7449fb36c6c8 ("migration/save: pass checkpointed_stream from libxl to
> libxc")
> Reported-by: Olaf Hering <[email protected]>
> Signed-off-by: Andrew Cooper <[email protected]>
Reviewed-by: Jan Beulich <[email protected]>
> ---
> CC: Ian Jackson <[email protected]>
> CC: Wei Liu <[email protected]>
> CC: Olaf Hering <[email protected]>
>
> `xl migrate --debug` might not be perfect, but this at least brings it back to
> mostly working.
>
> I don't think dropping it is a sensible move. In particular, it is invaluable
> for testing the logdirty infrastructure when migrating a memtest VM.
>
> If anyone has a clever idea to fix the grant problem, then we can. It is
> after all a debug option, without any specific prescribed behaviour.
What is "the grant problem" referring to here? Neither anything above
nor the offending original commit has any reference to grants, or a
problem with them.
Jan
