On Fri, Jul 02, 2021 at 07:51:55PM +0200, Fabrice Fontaine wrote: > > I do agree that setting -Werror is generally perfectly valid for upstream. > However, for downstream packager, it is generally seen as an issue as > it will always raise unexepected build failures with older, newer, or > exotic toolchains, see > https://embeddedartistry.com/blog/2017/05/22/werror-is-not-your-friend. > It would be good to, at least, have an option to disable -Werror for > example through a XEN_DISABLE_WERROR.
Two people don't make it a majority opinion, but if this was a meeting this opinion would get a second. I don't know where everyone is on the spectrum, but I also strongly dislike -Werror yet do like -Wall and tend to get rid of warnings. -Werror is good for continuous integration systems, not so great for releases or active development. -Werror kind of seems like Stack Ranking, good for use during brief periods, but poor for long term continuous use. -- (\___(\___(\______ --=> 8-) EHM <=-- ______/)___/)___/) \BS ( | [email protected] PGP 87145445 | ) / \_CS\ | _____ -O #include <stddisclaimer.h> O- _____ | / _/ 8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445
