>>> On 21.02.18 at 15:02, <[email protected]> wrote: > @@ -872,7 +879,7 @@ map_grant_ref( > struct grant_table *lgt, *rgt; > struct vcpu *led; > grant_handle_t handle; > - unsigned long frame = 0; > + mfn_t frame = _mfn(0);
If the initializer is needed at all, I think it should again become INVALID_MFN. Same in a few other places. > --- a/xen/include/asm-x86/grant_table.h > +++ b/xen/include/asm-x86/grant_table.h > @@ -76,7 +76,7 @@ static inline unsigned int gnttab_dom0_max(void) > #define gnttab_status_gmfn(d, t, i) \ > (mfn_to_gmfn(d, gnttab_status_mfn(t, i))) > > -#define gnttab_mark_dirty(d, f) paging_mark_dirty((d), _mfn(f)) > +#define gnttab_mark_dirty(d, f) paging_mark_dirty((d), f) Please take the opportunity and also drop the stray parentheses around d. With these taken care of and with Wei's R-b Acked-by: Jan Beulich <[email protected]> Jan _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
