>>> On 21.11.17 at 16:19, <[email protected]> wrote: > From: Michel Lespinasse <[email protected]> > > It is a well known property of rbtrees that insertion never requires more > than two tree rotations. In our implementation, after one loop iteration > identified one or two necessary tree rotations, we would iterate and look > for more. However at that point the node's parent would always be black, > which would cause us to exit the loop. > > We can make the code flow more obvious by just adding a break statement > after the tree rotations, where we know we are done. Additionally, in the > cases where two tree rotations are necessary, we don't have to update the > 'node' pointer as it wouldn't be used until the next loop iteration, which > we now avoid due to this break statement. > > Signed-off-by: Michel Lespinasse <[email protected]> > Cc: Andrea Arcangeli <[email protected]> > Acked-by: David Woodhouse <[email protected]> > Cc: Rik van Riel <[email protected]> > Cc: Peter Zijlstra <[email protected]> > Cc: Daniel Santos <[email protected]> > Cc: Jens Axboe <[email protected]> > Cc: "Eric W. Biederman" <[email protected]> > Signed-off-by: Andrew Morton <[email protected]> > Signed-off-by: Linus Torvalds <[email protected]> > [Linux commit 1f0528653e41ec230c60f5738820e8a544731399] > > Ported to Xen. > > Signed-off-by: Praveen Kumar <[email protected]>
Acked-by: Jan Beulich <[email protected]> _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
