At 08:06 -0700 on 12 Dec (1513065979), Jan Beulich wrote: > Following what we've already done in the XSA-250 fix, convert another > sh_pin() caller to no longer fail the higher level operation if pinning > fails, as pinning is a performance optimization only in those places. > > Suggested-by: Tim Deegan <[email protected]> > Signed-off-by: Jan Beulich <[email protected]>
Reviewed-by: Tim Deegan <[email protected]> > Would it be worth making sh_pin() return void, by adding a bool > parameter which the other call site in sh_set_toplevel_shadow() could > use to indicate a ref is avalable to be used (instead of aquiring a > new one)? This would allow to drop another domain_crash(). No, let's keep the calling convention as it is, please. Cheers Tim. _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
