-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2013-09-03 17:33, schrieb Henri Verbeet: > On 3 September 2013 14:07, Stefan Dösinger <ste...@codeweavers.com> > wrote: >> I'm checking this in d3d9/d3d8/ddraw because we create textures >> for everything nowadays, even stand-alone surfaces. > For ddraw that's not true yet, but I think my preferred way to > handle this would be to introduce a WINED3DUSAGE_TEXTURE usage > flag, and then handle the format restrictions in resource_init() in > wined3d. I have a patch for ddraw that changes that, it's one of the changes necessary to make the ddraw version of this test pass.
My main issue with a WINED3DUSAGE_TEXTURE flag is that create_texture(USAGE_TEXTURE) seems a bit weird - we might as well call it create_texture(USAGE_I_REALLY_MEAN_IT). The other aspect is that the capability check is the main difference between SCRATCH and SYSMEM resources. Having the check in the client libraries makes it easier to handle SCRATCH resources in d3d8/9. Admittedly it is not enough to just handle the format this way. The POW2 restriction and maximum size checks would have to be moved as well. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJSJgQ1AAoJEN0/YqbEcdMwU1UP/RrVyhgHnisRuhzIQYkRLeaD jLR2MF2q4f7d39TnmuezL9pZD2xJrlwlKt+K/kM28h6PTux+I95uqMazVxX73+YO 2vyxLrNQrsuTUa/mKvGltxt5NiequQnyP6AGj5FV1vosfNzplJdz8Zrloo03SD/R ZrBvyT11C88PdEY0hd6N9m/RQMzxeSJpMHIL9jsu2AjhZHNVSC8O5CdtuOLsqQOu jWJH+6MhOlAtfmntR4iJg6tUdouDcHZFMfD4ThJ6yldbf7l32L6ozjhm/+yGzy3I BV9nEmUbp78pKbVQjQBvJ8aFEJMmiEX1SCuSgWdq/XgCuZnmUhGgkXoU3MKSSWzu i3+1PX2iqa7XqtgrtPbGehxdCWhZuAm3B4lTOF7+Sky6hd7AnQYUoEZqUIsp551H 2qLXpFgHUCzJR6d36FsW+uODCdcX9V6RYzY/JNqU3dpVrxOUts1Yn/HIow40yN1x 4+m19wZ8EYuEPPjtBp5RhBMi2AVhZgaDXSOdIvFmTHeTQ2r8KhDR0jQKIrVZBVXX ZUoLXu8SKSVNKy9BCwUrC79zGGpG9UWsc3dJXwbOclT+7dAuUUrYn6kiyGi6j7cA UK3KQ1JV1pl37ePyyFSolOjmKzHY4dlD6Ov5Tcr7NQKd6PZt13Wn3HNyKIFHrfRX fZIWpjCeoXRvRx6ieGdA =Ljrf -----END PGP SIGNATURE-----
