Seems ok, though a small comment explaining the issue this patch fixes probably wouldn't hurt.
On 25 April 2013 20:43, Matteo Bruni <mbr...@codeweavers.com> wrote: > + if (target == GL_READ_FRAMEBUFFER) > + context_bind_fbo(context, GL_DRAW_FRAMEBUFFER, draw_binding ? > &draw_binding : 0); > + else > + context_bind_fbo(context, GL_READ_FRAMEBUFFER, read_binding ? > &read_binding : 0); > I don't think using 0 here is strictly wrong, but a proper NULL would probably be clearer. As a followup, I think we can actually get rid of the glGenFramebuffers() in context_bind_fbo() these days and just pass a GLuint instead of a pointer. The only place left that actually creates FBOs should be context_apply_fbo_entry().
