-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2013-04-10 14:28, schrieb Henri Verbeet:> Why do you need the sampler type for anything other than SM1 pixel > shaders? I'm not sure what you mean exactly. There are 3 problems related to the sampler type:
*) RECT vs 2D samplers *) Shader declares a 2D sampler but e.g. a cube texture is bound *) SM 1 pixel shaders > Also, while in principle I'm all for not accessing wined3d_state > from the shader backend, I don't think there should be anything in > the command stream patches that would prevent that. Correct. But accessing the stateblock to access the state is a problem. Furthermore, we may have to recompile the shader if the app switches texture types, thus we want this in the compile args. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJRZVvQAAoJEN0/YqbEcdMwyYEP/1Ez745CKD3CxnYK7WNuG2L3 0MEqi0IcepR917nZXXg7Azq7gssVRsepusxgU6RxTaY2HjmgBZ5a4d/XWBOiWnsl Z3rf4HMtHGQVunE1Nr8jQs0J01Ak0/pdp/po856Fy6BYJVQWx773glj3xa7RK5LP GRm8U4sD9SirC0vIdOnKlU9pBrCRtWC6c5TjJm57WFaGEujIt6q8SL7bqe1Sct+0 lKR4WO+66iUfNwCYsbLUT/mt5zwdVeiqmi5CtRYRMvTn972cKpYh1Lsyd3Xr45Ok ZZSQ4iQn3g6l2i9A5kSJw0tiVjNTKdc4+S9UhOuQsSXusXr1lvkrl9wrwgG+sXK0 Dt4cKdjNh3TIt+OcQ2R1jvqU3dkQlD8wj3aBtXJf6U0OQTSjc/0iCXy00yyoNwsM ZrVlT7DoLQ5+fMAbWy6RdXqONpEbEF6wxN/UCMJtyC+UUns4oyp5ndygKVoub1l0 PmkWQEX8GbsKu4q81OjIp4cdouEsIkkrVanDy+keYvX+ykxRGq0qg2+lVltYz3RJ 6Lb5SeK+Ky9TLJNL3mo0Xi0fQ0VCXti3t+5X4MwlDQ7gqLoEqGCBvC/coSInFuJO zlOaK8Jan/sh8uwH2WKcfa8HK2vI2d1MBtMd1om2SWGH2SlMVML2D4tVXZjlMzC1 Je8PniI9/LVi/UXE6Asn =eFtc -----END PGP SIGNATURE-----