On 27.09.2012 09:56, Nozomi Kodama wrote:
+FLOAT* WINAPI D3DXSHMultiply4(FLOAT *out, CONST FLOAT *a, CONST FLOAT *b)
FLOAT * WINAPI D3DXSHMultiply4(FLOAT *out, const FLOAT *a, const FLOAT *b)
A minor nitpick, anyone against something like? I think that was what Matteo meant in http://www.winehq.org/pipermail/wine-devel/2012-September/096924.html with "Fix the FLOAT*"?

+    TRACE("(%p, %p, %p)\n", out, a, b);
I would probably prefer:
TRACE("out %p, a %p, b %p\n", out, a, b);
I know the other Multiply functions and so on use your trace format...

+    out[0]  = 0.28209479f * a[0] * b[0];
There are still double spaces ... Hint: it's not the only occurrence.

Cheers
Rico


Reply via email to