Hi Detlef, I almost cleanup every thing according to the review. If i couldnt get anything, i want to talk to u on irc personally or thru mail personally. As i put that patch in 15mins after seeing thru ur mail. I really couldnt find a test app which tests that option. So i wrote a sample program, which i incorporated in the tests.
Thanks, Vijay PS: ----- I want to talk 2 u personally reg this patch on irc. Yes, i am a very bad programmer. On 3/4/06, Detlef Riekenberg <[EMAIL PROTECTED]> wrote: > Am Freitag, den 03.03.2006, 20:50 +0530 schrieb Vijay Kiran Kamuju: > > > Changes made according to some suggestions Detlef, waiting for more > > - It took me a really long time to write the review, but you ignored > almost everything > > I suggest, that you do what i did before sending patches to wine: > > Write a small Windows-App that call the Function, what you want to test > and learn, how it works. I'm still using PellesC 3.0 in wine for this. > > > > Add More tests for InternetQueryOption > > Add Tests for InternetSetOption > > Make the Patch as small as possible, so please test only one function. > > When you compile, there must be no warnings from the compiler! > (exception atm.: -fPIC on "make crosstest" in wine) > > Hope, that helps > > -- > By By ... > ... Detlef > >
