Re: ntdll/time.c - TZ_INFO

[Marcelo Duarte]

Thank you Tom.
Changelog:
-Correct time zone for BRT and BRST.
-Better explained fixme.

Tom escreveu:

Marcelo Duarte wrote:

Uwe Bonnes escreveu:

"Marcelo" == Marcelo Duarte <[EMAIL PROTECTED]> writes:

Marcelo> Hi, In my system/language I see some messages:
Marcelo> fixme:ntdll:TIME_GetTZAsStr Can't match system time zone name
Marcelo> "BRST" to an entry in TZ_INFO fixme:ntdll:TIME_GetTZAsStr
Marcelo> Please add appropriate entry to TZ_INFO and submit as patch to
Marcelo> wine-patches

Marcelo> And before to update TZ_INFO I modifyied the FIXME and I think
Marcelo> that it explain better the problem: fixme:ntdll:TIME_GetTZAsStr
Marcelo> Can't match system time zone name "BRST", bias=120 and dst=1 to
Marcelo> an entry in TZ_INFO. Please add appropriate entry to TZ_INFO
Marcelo> and submit as patch to wine-patches

Marcelo> And I see the real problem. In TZ_INFO bias=180 and dst=0. I
Marcelo> added another BRST information. Is this correct?

I don't live in the Brasilian Timezone, so I cant tell. Maybe the old entry
was wrong, or there is a mixup with standard and summer time...

Bye

There is a mixup. Standart use bias=180, dst=0 ans summer use bias=120, dst=1, but de same entry BRST. I dont know where to find information to do the correct behavior.

Hello,

BRT = Brasilia Time  -03:00 Offset from UTC
BRST= Brasilia Summer Time -02:00 Offset from UTC

Tom

Index: time.c
===================================================================
RCS file: /home/wine/wine/dlls/ntdll/time.c,v
retrieving revision 1.62
diff -u -p -r1.62 time.c
--- time.c	8 Feb 2005 12:13:36 -0000	1.62
+++ time.c	14 Feb 2005 05:25:09 -0000
@@ -145,11 +145,11 @@ static const struct tagTZ_INFO TZ_INFO[]
     {'N','e','w','f','o','u','n','d','l','a','n','d',' ','S','t','a','n','d',
      'a','r','d',' ','T','i','m','e','\0'}, 150, 1},
    {"BRT",
-    {'E','.',' ','S','o','u','t','h',' ','A','m','e','r','i','c','a',' ','S',
-     't','a','n','d','a','r','d',' ','T','i','m','e','\0'}, 180, 0},
+    {'B','r','a','z','i','l','i','a','n',' ','S','t','a','n','d','a','r','d',
+     ' ','T','i','m','e','\0'}, 180, 0},
    {"BRST",
-    {'E','.',' ','B','r','a','z','i','l','i','a','n',' ','S','t','a','n','d',
-     'a','r','d',' ','T','i','m','e','\0'}, 180, 0},
+    {'B','r','a','z','i','l','i','a','n',' ','S','u','m','m','e','r',
+     ' ','T','i','m','e','\0'}, 120, 1},
    {"ART",
     {'S','A',' ','E','a','s','t','e','r','n',' ','S','t','a','n','d','a','r',
      'd',' ','T','i','m','e','\0'}, 180, 0},
@@ -815,8 +815,9 @@ static const WCHAR* TIME_GetTZAsStr (tim
          )
             return TZ_INFO[i].psTZWindows;
    }
-   FIXME("Can't match system time zone name \"%s\" to an entry in TZ_INFO\n",psTZName);
-   FIXME(" Please add appropriate entry to TZ_INFO and submit as patch to wine-patches\n");
+   FIXME("Can't match system time zone name \"%s\", bias=%d and dst=%d "
+         "to an entry in TZ_INFO. Please add appropriate entry to "
+         "TZ_INFO and submit as patch to wine-patches\n",psTZName,bias,dst);
    return NULL;
 }