Oops! I forgot that we had already gone through the nomination process for Saam.
Sam and I were talking about making Saam a reviewer right when you landed this patch. We counted his patches at 75, though, and we thought we couldn’t nominate him yet. It looks like we miscounted, though, and Saam’s true patch count is 91. Geoff > On Aug 4, 2015, at 11:07 AM, Geoffrey Garen <[email protected]> wrote: > > Mark, > > While I am excited about Saam becoming a reviewer soon, this is the wrong > process. > > Please roll out this change and follow the procedure explained at > https://www.webkit.org/coding/commit-review-policy.html > <https://www.webkit.org/coding/commit-review-policy.html>. > > Thanks, > Geoff > >> On Aug 4, 2015, at 11:03 AM, [email protected] <mailto:[email protected]> >> wrote: >> >> Revision >> 187867 <http://trac.webkit.org/projects/webkit/changeset/187867>Author >> [email protected] <mailto:[email protected]>Date >> 2015-08-04 11:03:30 -0700 (Tue, 04 Aug 2015) >> Log Message >> >> Unreviewed. Make Saam Barati a WebKit reviewer. >> >> * Scripts/webkitpy/common/config/contributors.json: >> Modified Paths >> >> trunk/Tools/ChangeLog <x-msg://8/#trunkToolsChangeLog> >> trunk/Tools/Scripts/webkitpy/common/config/contributors.json >> <x-msg://8/#trunkToolsScriptswebkitpycommonconfigcontributorsjson> >> Diff >> >> <>Modified: trunk/Tools/ChangeLog (187866 => 187867) >> >> --- trunk/Tools/ChangeLog 2015-08-04 17:48:59 UTC (rev 187866) >> +++ trunk/Tools/ChangeLog 2015-08-04 18:03:30 UTC (rev 187867) >> @@ -1,3 +1,9 @@ >> +2015-08-04 Mark Lam <[email protected] <mailto:[email protected]>> >> + >> + Unreviewed. Make Saam Barati a WebKit reviewer. >> + >> + * Scripts/webkitpy/common/config/contributors.json: >> + >> 2015-08-04 Xabier Rodriguez Calvar <[email protected] >> <mailto:[email protected]>> >> >> Unreviewed, updated Streams API watchlist. >> <>Modified: trunk/Tools/Scripts/webkitpy/common/config/contributors.json >> (187866 => 187867) >> >> --- trunk/Tools/Scripts/webkitpy/common/config/contributors.json >> 2015-08-04 17:48:59 UTC (rev 187866) >> +++ trunk/Tools/Scripts/webkitpy/common/config/contributors.json >> 2015-08-04 18:03:30 UTC (rev 187867) >> @@ -2450,14 +2450,6 @@ >> "ryuan" >> ] >> }, >> - "Saam Barati" : { >> - "emails" : [ >> - "[email protected] <mailto:[email protected]>" >> - ], >> - "nicks" : [ >> - "saamyjoon" >> - ] >> - }, >> "Sadrul Habib Chowdhury" : { >> "emails" : [ >> "[email protected] <mailto:[email protected]>" >> @@ -4663,6 +4655,14 @@ >> "weinig" >> ] >> }, >> + "Saam Barati" : { >> + "emails" : [ >> + "[email protected] <mailto:[email protected]>" >> + ], >> + "nicks" : [ >> + "saamyjoon" >> + ] >> + }, >> "Sergio Villar Senin" : { >> "emails" : [ >> "[email protected] <mailto:[email protected]>", >> _______________________________________________ >> webkit-changes mailing list >> [email protected] <mailto:[email protected]> >> https://lists.webkit.org/mailman/listinfo/webkit-changes >> <https://lists.webkit.org/mailman/listinfo/webkit-changes>
_______________________________________________ webkit-dev mailing list [email protected] https://lists.webkit.org/mailman/listinfo/webkit-dev
