Clarifying the error messages seems like a win in either case. >From Android's perspective, I'm of course in favor of switching to ninja. One minor nit, but I'll reply with that on the bug. Thanks for doing this!
Peter On Mon, Dec 10, 2012 at 9:39 AM, Eric Seidel <[email protected]> wrote: > The buildbots will use ninja by default, but could opt-out (with > --no-ninja) if that were desired behavior. > > > I've so far received one other concern: > Robert Hogan raised that chromium's depot_tools does not contain a > 32-bit build of ninja, and the error message is somewhat confusing in > that case. I've filed https://bugs.webkit.org/show_bug.cgi?id=104523 > for tracking that issue. > > On Mon, Dec 10, 2012 at 1:30 AM, Jochen Eisinger <[email protected]> > wrote: > > Will the buildbots use ninja or the "native" build tools? > > > > My only concern is that we're catching problems with e.g. MSVS only > after we > > roll the WebKit deps in chromium and one of the MSVS bots starts failing. > > > > Otherwise, I'm all for switching to ninja. > > > > best > > -jochen > > > > On Sat, Dec 8, 2012 at 9:29 AM, Eric Seidel <[email protected]> wrote: > >> > >> If you don't work on the Chromium port, feel free to ignore. > >> > >> > >> If you work on the Chromium port of WebKit and do not use Ninja as you > >> build system (GYP_GENERATORS='ninja' or update-webkit --chromium > >> --ninja) I want to hear from you! > >> > >> As far as I can tell, the vast majority of Chromium contributors use > >> Ninja as their build system of choice. Particularly for > >> Chromium-Android contributors this seems to be true. > >> > >> With that knowledge, I have posted a patch to make update-webkit > >> ---chromium/--chromium-android generate Ninja build files instead of > >> platform-native build files (XCode, Visual Studio, Make, etc.) by > >> default. This of course only affects the chromium port. > >> > >> https://bugs.webkit.org/show_bug.cgi?id=104434 > >> > >> Thanks! > >> > >> > >> p.s. If you don't already know: > >> update-webkit --chromium --ninja > >> build-webkit --chromium > >> is all you need to use Ninja today. You don't even need to have > >> installed/built your own copy of ninja (Chromium has done that for > >> you). > >> > >> p.p.s. Ninja is awesome. Awesomely quiet. Awesomely fast. > >> http://martine.github.com/ninja/ > >> _______________________________________________ > >> webkit-dev mailing list > >> [email protected] > >> http://lists.webkit.org/mailman/listinfo/webkit-dev > > > > > _______________________________________________ > webkit-dev mailing list > [email protected] > http://lists.webkit.org/mailman/listinfo/webkit-dev >
_______________________________________________ webkit-dev mailing list [email protected] http://lists.webkit.org/mailman/listinfo/webkit-dev
