I've removed ENABLE_SVG_FOREIGN_OBJECT in http://trac.webkit.org/changeset/95040
I'm going to let that one bake for a few hours before I land the rest of the ENABLE_SVG_* removal patches. Thank you everyone for your feedback. -eric On Tue, Sep 13, 2011 at 11:28 AM, Jarred Nicholls <[email protected]> wrote: > On Tue, Sep 13, 2011 at 11:27 AM, Eric Seidel <[email protected]> wrote: >> >> Folks can track the general task of feature removal at: >> https://bugs.webkit.org/show_bug.cgi?id=68012 > > Nice this is helpful, thanks. > >> >> I will link all the "Remove ENABLE_*" bugs to that one. >> >> -eric >> >> On Tue, Sep 13, 2011 at 11:20 AM, Eric Seidel <[email protected]> wrote: >> > Hearing no objections to removing any of the sub-defines, I will post >> > a patch to do so shortly. >> > >> > I'll leave the ENABLE_SVG define for now. >> > >> > -eric >> > >> > On Tue, Sep 13, 2011 at 11:12 AM, Baldeva, Arpit <[email protected]> >> > wrote: >> >> Same here. We disable SVG for code size reasons as well. It would be >> >> nice to continue to have the top level define for that purpose. >> >> >> >> Thanks! >> >> >> >> -----Original Message----- >> >> From: [email protected] >> >> [mailto:[email protected]] On Behalf Of Dan Minor >> >> Sent: Monday, September 12, 2011 7:07 AM >> >> To: [email protected] >> >> Subject: Re: [webkit-dev] Do you compile with ENABLE_SVG diabled? >> >> >> >> When doing ports to various embedded systems we often disable SVG to >> >> reduce the size of the resulting library. It would be nice to retain the >> >> top level ENABLE_SVG define for this purpose. >> >> >> >> Thanks, >> >> >> >> Dan >> >> >> >> On 09/09/2011 05:42 PM, Eric Seidel wrote: >> >>> I am interested in removing the ENABLE_SVG define, and all associated >> >>> sub-defines >> >>> >> >>> ENABLE_SVG_ANIMATION >> >>> ENABLE_SVG_AS_IMAGE >> >>> ENABLE_SVG_FONTS >> >>> ENABLE_SVG_FOREIGN_OBJECT >> >>> ENABLE_SVG_USE >> >>> >> >>> SVG is part of HTML5, and all major ports compile and ship with SVG >> >>> enabled (and have for years). >> >>> >> >>> Please let me know if you are compiling with ENABLE_SVG disabled. >> >>> >> >>> -eric >> >>> _______________________________________________ >> >>> webkit-dev mailing list >> >>> [email protected] >> >>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev >> >>> >> >> _______________________________________________ >> >> webkit-dev mailing list >> >> [email protected] >> >> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev >> >> >> >> _______________________________________________ >> >> webkit-dev mailing list >> >> [email protected] >> >> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev >> >> >> > >> _______________________________________________ >> webkit-dev mailing list >> [email protected] >> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > > > > -- > ................................................................ > Sencha > Jarred Nicholls, Senior Software Architect > @jarrednicholls > > _______________________________________________ webkit-dev mailing list [email protected] http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
