We do sometimes land changes that are reviewed on IRC and that don't
correspond to bugs. The main criteria for when this is appropriate are:
- the change is simple, and doesn't need many eyes looking at it;
- there is no historical trail to maintain, no one is going to look at
svn blame and wonder why this change was made 10 years ago.
A change that modifies cross platform code to fix a platform specific
(?) crash, and that doesn't even include a test case definitely needs
to be tracked in WebKit Bugzilla.
- WBR, Alexey Proskuryakov
06.07.2010, в 5:52, [email protected] написал(а):
Revision
62546
Author
[email protected]
Date
2010-07-06 05:52:30 -0700 (Tue, 06 Jul 2010)
Log Message
2010-07-06 Gustavo Noronha Silva <[email protected]>
Rubber-stamped by Xan Lopez.
Crash when hitting back on some pages
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=575236
Also NULL-check document, in hopes of fixing this hard to
reproduce crash that we are getting reported quite a bit.
* page/FrameView.cpp:
(WebCore::FrameView::windowClipRect):
Modified Paths
trunk/WebCore/ChangeLog
trunk/WebCore/page/FrameView.cpp
Diff
Modified: trunk/WebCore/ChangeLog (62545 => 62546)
--- trunk/WebCore/ChangeLog 2010-07-06 12:11:06 UTC (rev 62545)
+++ trunk/WebCore/ChangeLog 2010-07-06 12:52:30 UTC (rev 62546)
@@ -1,3 +1,16 @@
+2010-07-06 Gustavo Noronha Silva <[email protected]>
+
+ Rubber-stamped by Xan Lopez.
+
+ Crash when hitting back on some pages
+ http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=575236
+
+ Also NULL-check document, in hopes of fixing this hard to
+ reproduce crash that we are getting reported quite a bit.
+
+ * page/FrameView.cpp:
+ (WebCore::FrameView::windowClipRect):
+
2010-07-05 Ilya Tikhonovsky <[email protected]>
Reviewed by Yury Semikhatsky.
Modified: trunk/WebCore/page/FrameView.cpp (62545 => 62546)
--- trunk/WebCore/page/FrameView.cpp 2010-07-06 12:11:06 UTC (rev
62545)
+++ trunk/WebCore/page/FrameView.cpp 2010-07-06 12:52:30 UTC (rev
62546)
@@ -1670,7 +1670,7 @@
// Set our clip rect to be our contents.
IntRect clipRect = contentsToWindow(visibleContentRect(!
clipToContents));
- if (!m_frame || !m_frame->document()->ownerElement())
+ if (!m_frame || !m_frame->document() || !m_frame->document()-
>ownerElement())
return clipRect;
// Take our owner element and get the clip rect from the
enclosing layer.
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
_______________________________________________
webkit-dev mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
