Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 1a7ed8b60310a449e00ed6a8607746cf72176a49
https://github.com/WebKit/WebKit/commit/1a7ed8b60310a449e00ed6a8607746cf72176a49
Author: Alan Baradlay <[email protected]>
Date: 2025-12-16 (Tue, 16 Dec 2025)
Changed paths:
M LayoutTests/platform/ios/css3/flexbox/flexbox-baseline-expected.txt
M LayoutTests/platform/mac/css3/flexbox/flexbox-baseline-expected.txt
M Source/WebCore/rendering/RenderFlexibleBox.cpp
M Source/WebCore/rendering/RenderGrid.cpp
M Source/WebCore/rendering/RenderGrid.h
M Source/WebCore/rendering/RenderTable.cpp
M Source/WebCore/rendering/RenderTableSection.cpp
Log Message:
-----------
[cleanup] Modernize first/lastLineBaseline functions (RenderTable,
RenderTableSection, RenderGrid and RenderFlexibleBox)
https://bugs.webkit.org/show_bug.cgi?id=304256
Reviewed by Antti Koivisto.
In addition to modernizing, flooring to int is now consistent across renderers
(there's a slight change in functionality here for flex content -see tree dump
diff below)
(This is also in preparation for supporting subpixel inline layout)
* LayoutTests/platform/ios/css3/flexbox/flexbox-baseline-expected.txt:
* LayoutTests/platform/mac/css3/flexbox/flexbox-baseline-expected.txt:
* Source/WebCore/rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::firstLineBaseline const):
(WebCore::RenderFlexibleBox::lastLineBaseline const):
* Source/WebCore/rendering/RenderGrid.cpp:
(WebCore::RenderGrid::firstLineBaseline const):
(WebCore::RenderGrid::lastLineBaseline const):
(WebCore::RenderGrid::baselineGridItem const):
(WebCore::RenderGrid::getBaselineGridItem const): Deleted.
* Source/WebCore/rendering/RenderGrid.h:
* Source/WebCore/rendering/RenderTable.cpp:
(WebCore::RenderTable::firstLineBaseline const):
(WebCore::RenderTable::lastLineBaseline const):
* Source/WebCore/rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::firstLineBaseline const):
(WebCore::RenderTableSection::lastLineBaseline const):
Canonical link: https://commits.webkit.org/304539@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
