[webkit-changes] [WebKit/WebKit] bdac66: Cherry-pick 304319@main (43662ccbd5af). https://bu...

[Rob Buis]

  Branch: refs/heads/webkitglib/2.50
  Home:   https://github.com/WebKit/WebKit
  Commit: bdac6690294a6995ab9078ba85e3ab587cdb1e59
      
https://github.com/WebKit/WebKit/commit/bdac6690294a6995ab9078ba85e3ab587cdb1e59
  Author: Rob Buis <rb...@igalia.com>
  Date:   2025-12-12 (Fri, 12 Dec 2025)

  Changed paths:
    A LayoutTests/fast/css/checkVisibility-no-renderer-crash-expected.txt
    A LayoutTests/fast/css/checkVisibility-no-renderer-crash.html
    M Source/WebCore/dom/Element.cpp

  Log Message:
  -----------
  Cherry-pick 304319@main (43662ccbd5af). 
https://bugs.webkit.org/show_bug.cgi?id=302379

    [WebKit][Main] [ef80f3f18e6df299] ASAN_SEGV | 
WebCore::RenderView::zoomFactor; WebCore::Style::adjustValueForPageZoom; 
WebCore::Style::computeNonCalcLengthDouble
    https://bugs.webkit.org/show_bug.cgi?id=302379

    Reviewed by Tim Nguyen.

    In checkVisibility computedStyle is used, however this could use calc()
    in the computed style determination, and this may crash if the document has
    no RenderView associated.

    We can avoid this problem by implementing rule 1 from the specification [1].

    [1] https://drafts.csswg.org/cssom-view-1/#dom-element-checkvisibility

    Test: fast/css/checkVisibility-no-renderer-crash.html

    * LayoutTests/fast/css/checkVisibility-no-renderer-crash-expected.txt: 
Added.
    * LayoutTests/fast/css/checkVisibility-no-renderer-crash.html: Added.
    * Source/WebCore/dom/Element.cpp:
    (WebCore::Element::checkVisibility):

    Canonical link: https://commits.webkit.org/304319@main

Canonical link: https://commits.webkit.org/298234.319@webkitglib/2.50



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications