Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: a6f27ff8617c2a9440a92f48adf35267dccb07c2
https://github.com/WebKit/WebKit/commit/a6f27ff8617c2a9440a92f48adf35267dccb07c2
Author: Chris Dumez <[email protected]>
Date: 2025-12-12 (Fri, 12 Dec 2025)
Changed paths:
M Source/WebCore/platform/audio/AudioSession.h
M Source/WebCore/platform/audio/cocoa/AudioSessionCocoa.h
M Source/WebKit/UIProcess/Media/RemoteMediaSessionManagerProxy.h
M Source/WebKit/WebProcess/GPU/media/RemoteAudioSession.h
Log Message:
-----------
RemoteMediaSessionManagerProxy inherits ThreadSafeRefCounted from 2 base
classes
https://bugs.webkit.org/show_bug.cgi?id=304049
Reviewed by Jean-Yves Avenard.
RemoteMediaSessionManagerProxy inherits ThreadSafeRefCounted from 2 base
classes (WebCore::REMOTE_MEDIA_SESSION_MANAGER_BASE_CLASS and
WebCore::AudioSession when USE(AUDIO_SESSION) (which is true for Cocoa
ports).
This is not safe and could lead to use-after-free bugs. To address the
issue have AudioSession subclass AbstractThreadSafeRefCountedAndCanMakeWeakPtr
instead of ThreadSafeRefCountedAndCanMakeWeakPtr.
* Source/WebCore/platform/audio/AudioSession.h:
* Source/WebCore/platform/audio/cocoa/AudioSessionCocoa.h:
* Source/WebKit/UIProcess/Media/RemoteMediaSessionManagerProxy.h:
* Source/WebKit/WebProcess/GPU/media/RemoteAudioSession.h:
Canonical link: https://commits.webkit.org/304350@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
