Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: bfec65f58317e99a714d6e47a55025e834627c0f
https://github.com/WebKit/WebKit/commit/bfec65f58317e99a714d6e47a55025e834627c0f
Author: Chris Dumez <[email protected]>
Date: 2025-12-11 (Thu, 11 Dec 2025)
Changed paths:
M Source/WebCore/css/CSSFontFace.cpp
M Source/WebCore/css/CSSFontFace.h
M Source/WebCore/css/CSSFontFaceSet.cpp
M Source/WebCore/css/CSSFontFaceSource.cpp
M Source/WebCore/css/CSSFontFaceSource.h
M Source/WebCore/css/FontFace.cpp
M Source/WebCore/loader/FontLoadRequest.h
M Source/WebCore/loader/cache/CachedFontLoadRequest.h
M Source/WebCore/workers/WorkerFontLoadRequest.cpp
Log Message:
-----------
Regression(303516@main) Crash under CachedFontLoadRequest::fontLoaded
https://bugs.webkit.org/show_bug.cgi?id=303963
rdar://166072004
Reviewed by Geoffrey Garen, Ryosuke Niwa, and Per Arne Vollan.
Stop using CanMakeCheckedPtr for FontLoadRequestClient and use ref-counting
instead as it appears it is possible for the client to get destroyed otherwise
in the middle of a `fontLoaded()` call.
* Source/WebCore/css/CSSFontFace.cpp:
(WebCore::CSSFontFace::appendSources):
(WebCore::CSSFontFace::adoptSource):
(WebCore::CSSFontFace::opportunisticallyStartFontDataURLLoading):
(WebCore::CSSFontFace::hasSVGFontFaceSource const):
* Source/WebCore/css/CSSFontFace.h:
* Source/WebCore/css/CSSFontFaceSet.cpp:
(WebCore::CSSFontFaceSet::ensureLocalFontFacesForFamilyRegistered):
* Source/WebCore/css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::ref const):
(WebCore::CSSFontFaceSource::deref const):
* Source/WebCore/css/CSSFontFaceSource.h:
* Source/WebCore/css/FontFace.cpp:
(WebCore::populateFontFaceWithArrayBuffer):
* Source/WebCore/loader/FontLoadRequest.h:
* Source/WebCore/loader/cache/CachedFontLoadRequest.h:
* Source/WebCore/workers/WorkerFontLoadRequest.cpp:
(WebCore::WorkerFontLoadRequest::didFinishLoading):
(WebCore::WorkerFontLoadRequest::didFail):
Canonical link: https://commits.webkit.org/304322@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
