Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 13c821fd80104207b3609807a38aabb458fc2f4e
https://github.com/WebKit/WebKit/commit/13c821fd80104207b3609807a38aabb458fc2f4e
Author: Chris Dumez <[email protected]>
Date: 2025-12-09 (Tue, 09 Dec 2025)
Changed paths:
M Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp
M Source/WebCore/rendering/GridTrackSizingAlgorithm.h
M Source/WebCore/rendering/RenderGrid.cpp
Log Message:
-----------
Drop unnecessary IsDeprecatedWeakRefSmartPointerException for GridTrack
https://bugs.webkit.org/show_bug.cgi?id=303891
Reviewed by Alan Baradlay.
GridTrack was subclasses CanMakeWeakPtr but not CanMakeCheckedPtr or RefCounted,
which is no longer allowed for safety reasons. Given how it is used, I have
opted to have GridTrack subclass CanMakeCheckedPtr instead of CanMakeWeakPtr.
Existing was using vectors of WeakPtrs and assuming those pointers would never
be null so CheckedPtr seems better suited. Note that I had to make the object
heap-allocated because CanMakeCheckedPtr only works for heap-allocated objects.
* Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp:
(WebCore::GridTrackSizingAlgorithm::computeTrackBasedSize const):
(WebCore::GridTrackSizingAlgorithm::sizeTrackToFitSingleSpanMasonryGroup):
(WebCore::GridTrackSizingAlgorithm::sizeTrackToFitNonSpanningItem):
(WebCore::GridTrackSizingAlgorithm::spanningItemCrossesFlexibleSizedTracks
const):
(WebCore::GridTrackSizingAlgorithm::increaseSizesToAccommodateSpanningItems):
(WebCore::GridTrackSizingAlgorithm::increaseSizesToAccommodateSpanningItemsMasonry):
(WebCore::GridTrackSizingAlgorithm::increaseSizesToAccommodateSpanningItemsMasonryWithFlex):
(WebCore::sortByGridTrackGrowthPotential):
(WebCore::distributeItemIncurredIncreases):
(WebCore::GridTrackSizingAlgorithm::distributeSpaceToTracks const):
(WebCore::computeGridSpanSize):
(WebCore::GridTrackSizingAlgorithm::computeFlexFactorUnitSize const):
(WebCore::GridTrackSizingAlgorithm::computeFlexSizedTracksGrowth const):
(WebCore::GridTrackSizingAlgorithm::findFrUnitSize const):
(WebCore::GridTrackSizingAlgorithm::computeGridContainerIntrinsicSizes):
(WebCore::GridTrackSizingAlgorithmStrategy::minContributionForGridItem const):
(WebCore::IndefiniteSizeStrategy::maximizeTracks):
(WebCore::IndefiniteSizeStrategy::findUsedFlexFraction const):
(WebCore::DefiniteSizeStrategy::maximizeTracks):
(WebCore::GridTrackSizingAlgorithm::initializeTrackSizes):
(WebCore::GridTrackSizingAlgorithm::computeDefiniteAndIndefiniteItemsForMasonry):
(WebCore::GridTrackSizingAlgorithm::handleInfinityGrowthLimit):
(WebCore::GridTrackSizingAlgorithm::resolveIntrinsicTrackSizes):
(WebCore::GridTrackSizingAlgorithm::stretchFlexibleTracks):
(WebCore::GridTrackSizingAlgorithm::stretchAutoTracks):
(WebCore::GridTrackSizingAlgorithm::setup):
(WebCore::removeSubgridMarginBorderPaddingFromTracks):
(WebCore::GridTrackSizingAlgorithm::copyUsedTrackSizesForSubgrid):
(WebCore::GridTrackSizingAlgorithm::tracksAreWiderThanMinTrackBreadth const):
* Source/WebCore/rendering/GridTrackSizingAlgorithm.h:
(WebCore::GridTrackSizingAlgorithmStrategy::distributeSpaceToTracks const):
(WebCore::GridTrack::growthLimitIsInfinite const): Deleted.
(WebCore::GridTrack::infiniteGrowthPotential const): Deleted.
(WebCore::GridTrack::plannedSize const): Deleted.
(WebCore::GridTrack::setPlannedSize): Deleted.
(WebCore::GridTrack::tempSize const): Deleted.
(WebCore::GridTrack::infinitelyGrowable const): Deleted.
(WebCore::GridTrack::setInfinitelyGrowable): Deleted.
(WebCore::GridTrack::growthLimitCap const): Deleted.
(WebCore::GridTrack::isGrowthLimitBiggerThanBaseSize const): Deleted.
* Source/WebCore/rendering/RenderGrid.cpp:
(WebCore::RenderGrid::gridAreaBreadthForGridItemIncludingAlignmentOffsets
const):
(WebCore::RenderGrid::populateGridPositionsForDirection):
Canonical link: https://commits.webkit.org/304211@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
