Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 43de5fb39e91ed7f617543b6ef156db4ab5f0cd7
https://github.com/WebKit/WebKit/commit/43de5fb39e91ed7f617543b6ef156db4ab5f0cd7
Author: Wenson Hsieh <[email protected]>
Date: 2025-12-09 (Tue, 09 Dec 2025)
Changed paths:
M Source/WebKit/UIProcess/ios/WKContentViewInteraction.h
M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
M Source/WebKit/UIProcess/ios/WKTextInteractionWrapper.mm
Log Message:
-----------
REGRESSION (301162@main): Focusing an invisible input element still draws the
cursor with full opacity
https://bugs.webkit.org/show_bug.cgi?id=302876
rdar://165489471
Reviewed by Aditya Keerthi.
After the changes in 301162@main, the text selection shows up even when
focusing a hidden editable
element. Prior to that change, all codepaths that activated the selection would
be gated on the text
selection interaction not being suppressed due to the editable root being
hidden; however, we now
unconditionally activate the selection whenever the selection is reparented
(when "selection honors
overflow scrolling" is enabled). To fix this, we add a check to only
`-activateSelection` in the
case where the selection isn't being suppressed.
Already covered by 2 layout tests which are failing on internal bots (where
`SelectionHonorsOverflowScrolling` is enabled by default):
- editing/selection/ios/hide-selection-in-hidden-contenteditable-frame.html
- editing/selection/ios/hide-selection-in-hidden-contenteditable.html
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.h:
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _isSuppressingSelectionAssistant]):
Expose text selection suppression state as a readonly getter, so that we can
check it before
activating the selection below.
* Source/WebKit/UIProcess/ios/WKTextInteractionWrapper.mm:
(-[WKTextInteractionWrapper prepareToMoveSelectionContainer:]):
Canonical link: https://commits.webkit.org/304160@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
