Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ab15e4ea138a3601fc6346aea7717e7196aefb94
https://github.com/WebKit/WebKit/commit/ab15e4ea138a3601fc6346aea7717e7196aefb94
Author: Chris Dumez <[email protected]>
Date: 2025-12-05 (Fri, 05 Dec 2025)
Changed paths:
M Source/WebCore/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations
M Source/WebCore/accessibility/AXCoreObject.cpp
M Source/WebCore/accessibility/AXCoreObject.h
M Source/WebCore/accessibility/AXLiveRegionManager.cpp
M Source/WebCore/accessibility/cocoa/AXCoreObjectCocoa.mm
M Source/WebCore/animation/ScrollTimeline.cpp
M Source/WebCore/animation/ScrollTimeline.h
M Source/WebCore/animation/ViewTimeline.cpp
M Source/WebCore/animation/ViewTimeline.h
M Source/WebCore/bindings/js/JSDOMWindowCustom.cpp
M Source/WebCore/dom/Document.cpp
M Source/WebCore/dom/Document.h
M Source/WebCore/dom/Element.cpp
M Source/WebCore/dom/Element.h
M Source/WebCore/dom/SelectorQuery.cpp
M Source/WebCore/editing/CompositeEditCommand.cpp
M Source/WebCore/editing/CompositeEditCommand.h
M Source/WebCore/editing/MarkupAccumulator.cpp
M Source/WebCore/editing/MarkupAccumulator.h
M Source/WebCore/editing/VisiblePosition.cpp
M Source/WebCore/editing/cocoa/NodeHTMLConverter.mm
M Source/WebCore/html/CachedHTMLCollectionInlines.h
M Source/WebCore/html/HTMLCanvasElement.cpp
M Source/WebCore/html/HTMLCanvasElement.h
M Source/WebCore/html/HTMLFormControlsCollection.cpp
M Source/WebCore/loader/archive/ArchiveResourceCollection.cpp
M Source/WebCore/loader/cache/CachedImage.cpp
M Source/WebCore/mathml/MathMLSelectElement.cpp
M Source/WebCore/mathml/MathMLSelectElement.h
M Source/WebCore/page/AutoscrollController.cpp
M Source/WebCore/page/DebugPageOverlays.cpp
M Source/WebCore/page/DebugPageOverlays.h
M Source/WebCore/page/ElementTargetingController.cpp
M Source/WebCore/page/EventHandler.cpp
M Source/WebCore/page/FocusController.cpp
M Source/WebCore/page/Frame.h
M Source/WebCore/page/FrameTree.cpp
M Source/WebCore/page/FrameTree.h
M Source/WebCore/page/LargestContentfulPaint.cpp
M Source/WebCore/page/LocalFrame.cpp
M Source/WebCore/page/LocalFrame.h
M Source/WebCore/page/PerformanceEventTiming.cpp
M Source/WebCore/page/PerformanceEventTiming.h
M Source/WebCore/page/PointerCaptureController.cpp
M Source/WebCore/page/RemoteFrame.cpp
M Source/WebCore/page/RemoteFrame.h
M Source/WebCore/page/UserMessageHandlersNamespace.cpp
M Source/WebCore/page/UserMessageHandlersNamespace.h
M Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp
M Source/WebCore/page/writing-tools/WritingToolsController.mm
M Source/WebCore/platform/Widget.h
M Source/WebCore/platform/cocoa/WebAVPlayerLayer.h
M Source/WebCore/platform/cocoa/WebAVPlayerLayer.mm
M Source/WebCore/platform/cocoa/WebAVPlayerLayerView.mm
M Source/WebCore/platform/graphics/DisplayRefreshMonitorManager.cpp
M Source/WebCore/platform/graphics/DisplayRefreshMonitorManager.h
M Source/WebCore/platform/graphics/MediaResourceSniffer.cpp
M Source/WebCore/platform/graphics/MediaResourceSniffer.h
M Source/WebCore/platform/graphics/Path.cpp
M Source/WebCore/platform/graphics/Path.h
M Source/WebCore/platform/ios/PasteboardIOS.mm
M Source/WebCore/platform/ios/WidgetIOS.mm
M Source/WebCore/platform/ios/wak/WAKWindow.mm
M Source/WebCore/platform/mac/PlatformScreenMac.mm
M Source/WebCore/platform/mac/WebCoreFullScreenPlaceholderView.mm
M Source/WebCore/platform/mac/WidgetMac.mm
M Source/WebCore/rendering/HitTestResult.cpp
M Source/WebCore/rendering/HitTestResult.h
M Source/WebCore/rendering/RenderBlockFlow.cpp
M Source/WebCore/rendering/RenderImage.cpp
M Source/WebCore/rendering/TextBoxTrimmer.cpp
M Source/WebCore/rendering/TextBoxTrimmer.h
M Source/WebCore/rendering/svg/RenderSVGModelObject.cpp
M Source/WebCore/rendering/svg/legacy/SVGResources.cpp
M Source/WebCore/rendering/updating/RenderTreeBuilderInline.cpp
M Source/WebCore/rendering/updating/RenderTreeBuilderInline.h
M Source/WebCore/rendering/updating/RenderTreeBuilderRuby.cpp
M Source/WebCore/style/ContainerQueryEvaluator.cpp
M Source/WebCore/style/ContainerQueryEvaluator.h
M Source/WebCore/style/Styleable.cpp
M Source/WebCore/svg/SVGSVGElement.cpp
M Source/WebCore/svg/SVGSVGElement.h
M Source/WebCore/testing/Internals.cpp
M Source/WebCore/testing/Internals.h
M Source/WebKitLegacy/mac/Misc/WebElementDictionary.mm
M Source/WebKitLegacy/mac/WebView/WebFrame.mm
Log Message:
-----------
Further reduce use of unsafeGet() in WebCore/
https://bugs.webkit.org/show_bug.cgi?id=303447
Reviewed by Geoffrey Garen.
* Source/WebCore/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations:
* Source/WebCore/accessibility/AXCoreObject.cpp:
(WebCore::AXCoreObject::hasUnignoredChild):
(WebCore::AXCoreObject::nextInPreOrder):
(WebCore::AXCoreObject::previousInPreOrder):
(WebCore::AXCoreObject::nextSiblingIncludingIgnoredOrParent const):
(WebCore::AXCoreObject::parentObjectUnignored const):
(WebCore::AXCoreObject::firstUnignoredChild): Deleted.
* Source/WebCore/accessibility/AXCoreObject.h:
(WebCore::AXCoreObject::hasUnignoredChild):
(WebCore::AXCoreObject::firstUnignoredChild): Deleted.
* Source/WebCore/accessibility/AXLiveRegionManager.cpp:
(WebCore::AXLiveRegionManager::shouldIncludeInSnapshot const):
* Source/WebCore/accessibility/cocoa/AXCoreObjectCocoa.mm:
(WebCore::AXCoreObject::rolePlatformString):
(WebCore::AXCoreObject::isEmptyGroup):
* Source/WebCore/animation/ScrollTimeline.cpp:
(WebCore::ScrollTimeline::bindingsSource const):
(WebCore::ScrollTimeline::source const):
* Source/WebCore/animation/ScrollTimeline.h:
* Source/WebCore/animation/ViewTimeline.cpp:
(WebCore::ViewTimeline::bindingsSource const):
(WebCore::ViewTimeline::source const):
* Source/WebCore/animation/ViewTimeline.h:
* Source/WebCore/bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::getOwnPropertySlotByIndex):
* Source/WebCore/dom/Document.cpp:
(WebCore::Document::scrollingElementForAPI):
(WebCore::Document::scrollingElement):
* Source/WebCore/dom/Document.h:
* Source/WebCore/dom/Element.cpp:
(WebCore::Element::topmostPopoverAncestor):
* Source/WebCore/dom/Element.h:
* Source/WebCore/dom/SelectorQuery.cpp:
(WebCore::filterRootById):
(WebCore::SelectorDataList::execute const):
* Source/WebCore/editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::ensureComposition):
(WebCore::CompositeEditCommand::applyCommandToComposite):
* Source/WebCore/editing/CompositeEditCommand.h:
* Source/WebCore/editing/MarkupAccumulator.cpp:
(WebCore::MarkupAccumulator::suitableShadowRoot):
* Source/WebCore/editing/MarkupAccumulator.h:
* Source/WebCore/editing/VisiblePosition.cpp:
(WebCore::VisiblePosition::localCaretRect const):
* Source/WebCore/editing/cocoa/NodeHTMLConverter.mm:
(HTMLConverter::_blockLevelElementForNode):
(HTMLConverter::computedAttributesForElement):
(HTMLConverter::aggregatedAttributesForAncestors):
(HTMLConverter::aggregatedAttributesForElementAndItsAncestors):
(HTMLConverter::_processElement):
(HTMLConverter::_processText):
* Source/WebCore/html/CachedHTMLCollectionInlines.h:
(WebCore::traversalType>::namedItem const):
* Source/WebCore/html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::getContext):
(WebCore::HTMLCanvasElement::createContextWebGL):
(WebCore::HTMLCanvasElement::getContextWebGL):
* Source/WebCore/html/HTMLCanvasElement.h:
* Source/WebCore/html/HTMLFormControlsCollection.cpp:
(WebCore::HTMLFormControlsCollection::customElementAfter const):
* Source/WebCore/loader/archive/ArchiveResourceCollection.cpp:
(WebCore::ArchiveResourceCollection::archiveResourceForURL):
* Source/WebCore/loader/cache/CachedImage.cpp:
(WebCore::CachedImage::imageForRenderer):
* Source/WebCore/mathml/MathMLSelectElement.cpp:
(WebCore::MathMLSelectElement::getSelectedActionChild):
(WebCore::MathMLSelectElement::getSelectedSemanticsChild):
(WebCore::MathMLSelectElement::updateSelectedChild):
* Source/WebCore/mathml/MathMLSelectElement.h:
* Source/WebCore/page/AutoscrollController.cpp:
(WebCore::AutoscrollController::updateDragAndDrop):
* Source/WebCore/page/DebugPageOverlays.cpp:
(WebCore::DebugPageOverlays::ensureRegionOverlayForPage):
(WebCore::DebugPageOverlays::showRegionOverlay):
* Source/WebCore/page/DebugPageOverlays.h:
* Source/WebCore/page/ElementTargetingController.cpp:
(WebCore::querySelectorMatchesOneElement):
(WebCore::findOnlyMainElement):
(WebCore::searchForElementContainingText):
(WebCore::elementToAdjust):
* Source/WebCore/page/EventHandler.cpp:
(WebCore::nodeToSelectOnMouseDownForNode):
* Source/WebCore/page/FocusController.cpp:
(WebCore::openPopoverForInvoker):
(WebCore::FocusController::findFocusableElementAcrossFocusScope):
* Source/WebCore/page/Frame.h:
* Source/WebCore/page/FrameTree.cpp:
(WebCore::FrameTree::scopedChild const):
(WebCore::FrameTree::scopedChildByUniqueName const):
(WebCore::FrameTree::scopedChildBySpecifiedName const):
(WebCore::FrameTree::find const):
(WebCore::FrameTree::findByUniqueName const):
(WebCore::FrameTree::findBySpecifiedName const):
* Source/WebCore/page/FrameTree.h:
* Source/WebCore/page/LargestContentfulPaint.cpp:
(WebCore::LargestContentfulPaint::element const):
* Source/WebCore/page/LocalFrame.cpp:
(WebCore::LocalFrame::frameDocumentSecurityOrigin const):
* Source/WebCore/page/LocalFrame.h:
* Source/WebCore/page/PerformanceEventTiming.cpp:
(WebCore::PerformanceEventTiming::target const):
* Source/WebCore/page/PerformanceEventTiming.h:
* Source/WebCore/page/PointerCaptureController.cpp:
(WebCore::PointerCaptureController::pointerCaptureElement const):
* Source/WebCore/page/RemoteFrame.cpp:
(WebCore::RemoteFrame::frameDocumentSecurityOrigin const):
(WebCore::RemoteFrame::frameDocumentSecurityOriginOrOpaque const):
* Source/WebCore/page/RemoteFrame.h:
* Source/WebCore/page/UserMessageHandlersNamespace.cpp:
(WebCore::UserMessageHandlersNamespace::namedItem):
* Source/WebCore/page/UserMessageHandlersNamespace.h:
* Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp:
(WebCore::AsyncScrollingCoordinator::frameViewForScrollingNode const):
* Source/WebCore/page/writing-tools/WritingToolsController.mm:
(WebCore::WritingToolsController::smartReplySessionDidReceiveTextWithReplacementRange):
(WebCore::WritingToolsController::compositionSessionDidReceiveTextWithReplacementRangeAsync):
(WebCore::appliedCommandIsWritingToolsCommand):
(WebCore::WritingToolsController::showOriginalCompositionForSession):
(WebCore::WritingToolsController::showRewrittenCompositionForSession):
* Source/WebCore/platform/Widget.h:
* Source/WebCore/platform/cocoa/WebAVPlayerLayer.h:
* Source/WebCore/platform/cocoa/WebAVPlayerLayer.mm:
(-[WebAVPlayerLayer presentationModel]):
(-[WebAVPlayerLayer setPresentationModel:]):
* Source/WebCore/platform/cocoa/WebAVPlayerLayerView.mm:
(WebCore::WebAVPlayerLayerView_pictureInPicturePlayerLayerView):
* Source/WebCore/platform/graphics/DisplayRefreshMonitorManager.cpp:
(WebCore::DisplayRefreshMonitorManager::monitorForClient):
* Source/WebCore/platform/graphics/DisplayRefreshMonitorManager.h:
* Source/WebCore/platform/graphics/MediaResourceSniffer.cpp:
(WebCore::MediaResourceSniffer::promise const):
* Source/WebCore/platform/graphics/MediaResourceSniffer.h:
* Source/WebCore/platform/graphics/Path.cpp:
(WebCore::Path::ensureImpl):
(WebCore::Path::asImpl):
(WebCore::Path::asImpl const):
(WebCore::Path::asProtectedImpl):
(WebCore::Path::asProtectedImpl const):
(WebCore::Path::applySegments const):
(WebCore::Path::applyElements const):
(WebCore::Path::transform):
(WebCore::Path::singleSegment const):
(WebCore::Path::segmentsIfExists const):
(WebCore::Path::isClosed const):
(WebCore::Path::hasSubpaths const):
(WebCore::Path::fastBoundingRect const):
(WebCore::Path::boundingRect const):
* Source/WebCore/platform/graphics/Path.h:
(WebCore::Path::currentPoint const):
* Source/WebCore/platform/ios/PasteboardIOS.mm:
(WebCore::Pasteboard::read):
(WebCore::Pasteboard::readRespectingUTIFidelities):
(WebCore::Pasteboard::readPlatformValuesAsStrings):
(WebCore::Pasteboard::readFilePaths):
* Source/WebCore/platform/ios/WidgetIOS.mm:
(WebCore::Widget::setFrameRect):
(WebCore::Widget::outerView const):
(WebCore::Widget::paint):
(WebCore::Widget::addToSuperview):
(WebCore::Widget::removeFromSuperview):
* Source/WebCore/platform/ios/wak/WAKWindow.mm:
(-[WAKWindow contentReplacementImage]):
* Source/WebCore/platform/mac/PlatformScreenMac.mm:
(WebCore::screen):
* Source/WebCore/platform/mac/WebCoreFullScreenPlaceholderView.mm:
(-[WebCoreFullScreenPlaceholderView target]):
* Source/WebCore/platform/mac/WidgetMac.mm:
(WebCore::Widget::show):
(WebCore::Widget::hide):
(WebCore::Widget::frameRect const):
(WebCore::Widget::outerView const):
(WebCore::Widget::removeFromSuperview):
(WebCore::Widget::protectedOuterView const): Deleted.
* Source/WebCore/rendering/HitTestResult.cpp:
(WebCore::HitTestResult::targetFrame const):
* Source/WebCore/rendering/HitTestResult.h:
* Source/WebCore/rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::layoutInFlowChildren):
* Source/WebCore/rendering/RenderImage.cpp:
(WebCore::RenderImage::paintIntoRect):
* Source/WebCore/rendering/TextBoxTrimmer.cpp:
(WebCore::firstFormattedLineRoot):
(WebCore::lastFormattedLineRoot):
(WebCore::TextBoxTrimmer::lastInlineFormattingContextRootForTrimEnd):
* Source/WebCore/rendering/TextBoxTrimmer.h:
* Source/WebCore/rendering/svg/RenderSVGModelObject.cpp:
(WebCore::RenderSVGModelObject::pushMappingToContainer const):
* Source/WebCore/rendering/svg/legacy/SVGResources.cpp:
(WebCore::paintingResourceFromSVGPaint):
(WebCore::SVGResources::buildCachedResources):
* Source/WebCore/rendering/updating/RenderTreeBuilderInline.cpp:
(WebCore::RenderTreeBuilder::Inline::parentCandidateInContinuation):
(WebCore::RenderTreeBuilder::Inline::insertChildToContinuation):
* Source/WebCore/rendering/updating/RenderTreeBuilderInline.h:
* Source/WebCore/rendering/updating/RenderTreeBuilderRuby.cpp:
(WebCore::RenderTreeBuilder::Ruby::findOrCreateParentForStyleBasedRubyChild):
* Source/WebCore/style/ContainerQueryEvaluator.cpp:
(WebCore::Style::ContainerQueryEvaluator::selectContainer):
* Source/WebCore/style/ContainerQueryEvaluator.h:
* Source/WebCore/style/Styleable.cpp:
(WebCore::Styleable::renderer const):
* Source/WebCore/svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::getElementById):
* Source/WebCore/svg/SVGSVGElement.h:
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::insertTextPlaceholder):
* Source/WebCore/testing/Internals.h:
* Source/WebKitLegacy/mac/Misc/WebElementDictionary.mm:
(-[WebElementDictionary _targetWebFrame]):
* Source/WebKitLegacy/mac/WebView/WebFrame.mm:
(-[WebFrame findFrameNamed:]):
Canonical link: https://commits.webkit.org/304037@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
