Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 9dfee2008ef600793cc9bea4c10be3469f6efb75
https://github.com/WebKit/WebKit/commit/9dfee2008ef600793cc9bea4c10be3469f6efb75
Author: Megan Gardner <[email protected]>
Date: 2025-12-04 (Thu, 04 Dec 2025)
Changed paths:
M Source/WebKit/UIProcess/TextCheckerCompletion.cpp
M Source/WebKit/UIProcess/TextCheckerCompletion.h
Log Message:
-----------
Switch to WeakPtr for WebPageProxy in TextCheckerCompletion.
https://bugs.webkit.org/show_bug.cgi?id=303569
rdar://165860363
Reviewed by Wenson Hsieh.
When working on 303913@main one of the pieces of feedback
resulted in an empty class that then caused me to try and
use an empty Ref. This caused a crash. While the fix for that
issue was different, it exposed that the relationship between
TextCheckerCompletion and WebPageProxy was incorrect and we should
have an WeakPtr in the case that we've lost our WebPageProxy.
* Source/WebKit/UIProcess/TextCheckerCompletion.cpp:
(WebKit::TextCheckerCompletion::protectedPage const):
(WebKit::TextCheckerCompletion::spellDocumentTag):
(WebKit::TextCheckerCompletion::didFinishCheckingText const):
(WebKit::TextCheckerCompletion::didCancelCheckingText const):
* Source/WebKit/UIProcess/TextCheckerCompletion.h:
Canonical link: https://commits.webkit.org/303964@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
