Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1bac13ec19e9a11c7a5ed1b0741cce772a756b36
      
https://github.com/WebKit/WebKit/commit/1bac13ec19e9a11c7a5ed1b0741cce772a756b36
  Author: Fujii Hironori <[email protected]>
  Date:   2025-12-03 (Wed, 03 Dec 2025)

  Changed paths:
    M Source/WebCore/Modules/webxr/WebXRFrame.cpp

  Log Message:
  -----------
  [WebXR Hit Test] Crashing due to empty Ref<WebXRHitTestResult> returned by 
WebXRFrame::getHitTestResults
https://bugs.webkit.org/show_bug.cgi?id=303438

Reviewed by Sergio Villar Senin.

getHitTestResults and getHitTestResultsForTransientInput of WebXRFrame returned
empty Ref<WebXRHitTestResult>, and failed an release assertion in Ref::get.

> Vector<Ref<WebXRHitTestResult>> results(v.size());
> for (auto& x : v)
>     results.append(...);

This was a misuse of Vector. The Vector constructor added empty items to
results. Use Vector::map instead.

* Source/WebCore/Modules/webxr/WebXRFrame.cpp:
(WebCore::WebXRFrame::getHitTestResults):
(WebCore::WebXRFrame::getHitTestResultsForTransientInput):

Canonical link: https://commits.webkit.org/303814@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications

Reply via email to