Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 8aa1e5bdbca5cd799671d9336bfc488ed7f8de3e
https://github.com/WebKit/WebKit/commit/8aa1e5bdbca5cd799671d9336bfc488ed7f8de3e
Author: Sam Weinig <[email protected]>
Date: 2025-12-02 (Tue, 02 Dec 2025)
Changed paths:
M Source/WebCore/SaferCPPExpectations/UncheckedCallArgsCheckerExpectations
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/css/CSSProperties.json
M Source/WebCore/css/scripts/process-css-properties.py
M Source/WebCore/css/scripts/test/TestCSSProperties.json
M Source/WebCore/dom/Document.cpp
M Source/WebCore/history/CachedFrame.cpp
M
Source/WebCore/layout/formattingContexts/block/tablewrapper/TableWrapperBlockFormattingContext.cpp
M Source/WebCore/layout/formattingContexts/flex/FlexFormattingUtils.cpp
M Source/WebCore/layout/formattingContexts/inline/InlineContentAligner.cpp
M Source/WebCore/layout/formattingContexts/inline/InlineFormattingUtils.cpp
M Source/WebCore/layout/formattingContexts/inline/InlineLevelBoxInlines.h
M
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp
M Source/WebCore/layout/formattingContexts/table/TableFormattingState.cpp
M Source/WebCore/layout/layouttree/LayoutBox.cpp
M Source/WebCore/layout/layouttree/LayoutBox.h
M Source/WebCore/layout/layouttree/LayoutBoxInlines.h
M Source/WebCore/rendering/LegacyInlineBox.h
M Source/WebCore/rendering/RenderBox.h
M Source/WebCore/rendering/RenderBoxInlines.h
M Source/WebCore/rendering/RenderElement.h
M Source/WebCore/rendering/RenderElementInlines.h
M Source/WebCore/rendering/RenderLayer.cpp
M Source/WebCore/rendering/RenderLayer.h
M Source/WebCore/rendering/RenderLayerInlines.h
M Source/WebCore/rendering/RenderLayerModelObject.h
A Source/WebCore/rendering/RenderLayerModelObjectInlines.h
M Source/WebCore/rendering/TextAutoSizing.cpp
M Source/WebCore/rendering/style/RenderStyle.cpp
M Source/WebCore/rendering/style/RenderStyle.h
M Source/WebCore/rendering/style/RenderStyleInlines.h
M Source/WebCore/rendering/style/RenderStyleSetters.h
M Tools/Scripts/webkitpy/style/checkers/jsonchecker.py
Log Message:
-----------
[RenderStyleGen] Generate getter/setter functions that were missed
https://bugs.webkit.org/show_bug.cgi?id=303398
Reviewed by Darin Adler.
While I knew that a few classes of properties still did not have generated
getter/setters, I hadn't noticed that there were a bunch that were missed
just due to them being implemented in purely in RenderStyle.h. To ensure
that I didn't miss any more, I added a check to the generator that raises
an exception if the metadata necessary for getter/setter generation is not
available. As an escape hatch, we now exclude the following classes of
properties for that check:
- has the new "skip-render-style" entry (needed for a few internal
properties that don't have any storage, and for tests)
- is a logical property
- is a shorthand property
- is a cascade alias
- is a coordinated list value
For all other properties, either a storage path or being marked as having
a custom getter/setter is now required.
Due to some properties getter/setters now being available via
RenderStyleInlines.h
and RenderStyleSetters.h, rather than RenderStyle.h itself, a bit of shuffling
was
needed to avoid including those files in non-Inlines headers.
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/css/scripts/process-css-properties.py:
* Source/WebCore/css/scripts/test/TestCSSProperties.json:
* Source/WebCore/dom/Document.cpp:
* Source/WebCore/history/CachedFrame.cpp:
*
Source/WebCore/layout/formattingContexts/block/tablewrapper/TableWrapperBlockFormattingContext.cpp:
* Source/WebCore/layout/formattingContexts/flex/FlexFormattingUtils.cpp:
* Source/WebCore/layout/formattingContexts/inline/InlineContentAligner.cpp:
* Source/WebCore/layout/formattingContexts/inline/InlineFormattingUtils.cpp:
* Source/WebCore/layout/formattingContexts/inline/InlineLevelBoxInlines.h:
*
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:
* Source/WebCore/layout/formattingContexts/table/TableFormattingState.cpp:
* Source/WebCore/layout/layouttree/LayoutBox.cpp:
* Source/WebCore/layout/layouttree/LayoutBox.h:
* Source/WebCore/layout/layouttree/LayoutBoxInlines.h:
* Source/WebCore/rendering/LegacyInlineBox.h:
* Source/WebCore/rendering/RenderBox.h:
* Source/WebCore/rendering/RenderBoxInlines.h:
* Source/WebCore/rendering/RenderElement.h:
* Source/WebCore/rendering/RenderElementInlines.h:
* Source/WebCore/rendering/RenderLayer.cpp:
* Source/WebCore/rendering/RenderLayer.h:
* Source/WebCore/rendering/RenderLayerInlines.h:
* Source/WebCore/rendering/RenderLayerModelObject.h:
* Source/WebCore/rendering/RenderLayerModelObjectInlines.h: Added.
* Source/WebCore/rendering/TextAutoSizing.cpp:
* Source/WebCore/rendering/style/RenderStyle.cpp:
* Source/WebCore/rendering/style/RenderStyle.h:
* Source/WebCore/rendering/style/RenderStyleInlines.h:
* Source/WebCore/rendering/style/RenderStyleSetters.h:
* Tools/Scripts/webkitpy/style/checkers/jsonchecker.py:
Canonical link: https://commits.webkit.org/303805@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
