Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 0dda3d536adba7453f849e02deb2091ee38a11d0
https://github.com/WebKit/WebKit/commit/0dda3d536adba7453f849e02deb2091ee38a11d0
Author: Chris Dumez <[email protected]>
Date: 2025-12-02 (Tue, 02 Dec 2025)
Changed paths:
M Source/WebCore/Modules/cache/DOMCache.cpp
M Source/WebCore/Modules/compression/CompressionStreamEncoder.cpp
M Source/WebCore/Modules/compression/DecompressionStreamDecoder.cpp
M Source/WebCore/Modules/compression/cocoa/CompressionStreamEncoderCocoa.mm
M
Source/WebCore/Modules/compression/cocoa/DecompressionStreamDecoderCocoa.mm
M Source/WebCore/Modules/fetch/FetchBody.cpp
M Source/WebCore/Modules/fetch/FetchBodyConsumer.cpp
M Source/WebCore/Modules/fetch/FetchBodyConsumer.h
M Source/WebCore/Modules/identity/CredentialRequestCoordinator.cpp
M Source/WebCore/Modules/model-element/HTMLModelElement.cpp
M Source/WebCore/Modules/notifications/NotificationResourcesLoader.cpp
M Source/WebCore/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations
M Source/WebCore/accessibility/AXObjectCacheInlines.h
M Source/WebCore/accessibility/AXUtilities.cpp
M Source/WebCore/accessibility/AXUtilities.h
M Source/WebCore/accessibility/AccessibilityObject.cpp
M Source/WebCore/accessibility/AccessibilityObject.h
M Source/WebCore/accessibility/AccessibilityRenderObject.cpp
M Source/WebCore/accessibility/AccessibilityScrollView.cpp
M Source/WebCore/animation/StyleOriginatedTimelinesController.cpp
M Source/WebCore/css/CSSKeyframeRule.cpp
M Source/WebCore/css/CSSPrimitiveValueMappings.h
M Source/WebCore/css/ShorthandSerializer.cpp
M Source/WebCore/css/StyleRule.cpp
M Source/WebCore/dom/CharacterData.cpp
M Source/WebCore/dom/Document.cpp
M Source/WebCore/dom/Element.cpp
M Source/WebCore/dom/EventPath.h
M Source/WebCore/editing/CompositeEditCommand.cpp
M Source/WebCore/editing/Editing.cpp
M Source/WebCore/editing/Editing.h
M Source/WebCore/editing/Editor.cpp
M Source/WebCore/editing/TextIterator.cpp
M Source/WebCore/inspector/NetworkResourcesData.cpp
M Source/WebCore/loader/ResourceLoader.cpp
M Source/WebCore/loader/SubstituteResource.h
M Source/WebCore/loader/archive/mhtml/MHTMLArchive.cpp
M Source/WebCore/loader/archive/mhtml/MHTMLParser.cpp
M Source/WebCore/loader/ios/LegacyPreviewLoader.mm
M Source/WebCore/page/FocusController.cpp
M Source/WebCore/page/LocalFrame.cpp
M Source/WebCore/page/Page.cpp
M Source/WebCore/page/Page.h
M Source/WebCore/platform/PreviewConverter.cpp
M Source/WebCore/platform/SharedBuffer.cpp
M Source/WebCore/platform/SharedBuffer.h
M Source/WebCore/platform/graphics/MediaResourceSniffer.cpp
M
Source/WebCore/platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm
M Source/WebCore/platform/graphics/cocoa/SourceBufferParserWebM.cpp
M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
M Source/WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp
M Source/WebCore/platform/mediarecorder/MediaRecorderPrivateEncoder.cpp
M Source/WebCore/platform/mediarecorder/MediaRecorderPrivateGStreamer.cpp
M Source/WebCore/platform/network/cocoa/RangeResponseGenerator.mm
M Source/WebCore/workers/ScriptBuffer.cpp
M Source/WebCore/workers/ScriptBuffer.h
M Source/WebCore/workers/WorkerFontLoadRequest.cpp
M Source/WebCore/workers/service/server/SWScriptStorage.cpp
M Source/WebCore/xml/XMLHttpRequest.cpp
M Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp
M Source/WebKit/NetworkProcess/cache/NetworkCacheSpeculativeLoad.cpp
M Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm
M Source/WebKit/NetworkProcess/storage/BackgroundFetchStoreManager.cpp
M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in
M Source/WebKit/UIProcess/WebURLSchemeTask.cpp
M Source/WebKit/WebProcess/Plugins/PluginView.cpp
M Source/WebKit/WebProcess/Storage/WebServiceWorkerFetchTaskClient.cpp
M Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.cpp
M Source/WebKit/WebProcess/WebCoreSupport/ios/WebPreviewLoaderClient.cpp
M Tools/TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp
M Tools/TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm
Log Message:
-----------
Reduce use of unsafeGet() in WebCore/
https://bugs.webkit.org/show_bug.cgi?id=303291
Reviewed by Geoffrey Garen.
* Source/WebCore/Modules/cache/DOMCache.cpp:
(WebCore::DOMCache::addAll):
(WebCore::DOMCache::put):
* Source/WebCore/Modules/compression/CompressionStreamEncoder.cpp:
(WebCore::CompressionStreamEncoder::compressZlib):
* Source/WebCore/Modules/compression/DecompressionStreamDecoder.cpp:
(WebCore::DecompressionStreamDecoder::decompressZlib):
* Source/WebCore/Modules/compression/cocoa/CompressionStreamEncoderCocoa.mm:
(WebCore::CompressionStreamEncoder::compressAppleCompressionFramework):
* Source/WebCore/Modules/compression/cocoa/DecompressionStreamDecoderCocoa.mm:
(WebCore::DecompressionStreamDecoder::decompressAppleCompressionFramework):
* Source/WebCore/Modules/fetch/FetchBody.cpp:
(WebCore::FetchBody::convertReadableStreamToArrayBuffer):
* Source/WebCore/Modules/fetch/FetchBodyConsumer.cpp:
(WebCore::FetchBodyConsumer::resolveWithFormData):
(WebCore::FetchBodyConsumer::resolve):
(WebCore::FetchBodyConsumer::takeData):
(WebCore::FetchBodyConsumer::takeAsArrayBuffer):
(WebCore::FetchBodyConsumer::takeAsBlob):
(WebCore::FetchBodyConsumer::takeAsText):
(WebCore::FetchBodyConsumer::setSource):
* Source/WebCore/Modules/fetch/FetchBodyConsumer.h:
* Source/WebCore/Modules/identity/CredentialRequestCoordinator.cpp:
(WebCore::CredentialRequestCoordinator::CredentialRequestCoordinator):
(WebCore::CredentialRequestCoordinator::finalizeDigitalCredential):
* Source/WebCore/Modules/model-element/HTMLModelElement.cpp:
(WebCore::HTMLModelElement::createModelPlayer):
(WebCore::HTMLModelElement::reloadModelPlayer):
(WebCore::HTMLModelElement::environmentMapResourceFinished):
(WebCore::HTMLModelElement::modelResourceFinished):
* Source/WebCore/Modules/notifications/NotificationResourcesLoader.cpp:
(WebCore::NotificationResourcesLoader::ResourceLoader::didReceiveData):
(WebCore::NotificationResourcesLoader::ResourceLoader::didFinishLoading):
* Source/WebCore/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations:
* Source/WebCore/accessibility/AXObjectCacheInlines.h:
(WebCore::AXObjectCache::getOrCreate):
* Source/WebCore/accessibility/AXUtilities.cpp:
(WebCore::composedParentIgnoringDocumentFragments):
* Source/WebCore/accessibility/AXUtilities.h:
* Source/WebCore/accessibility/AccessibilityObject.cpp:
(WebCore::nearestRendererFromNode):
(WebCore::AccessibilityObject::rendererOrNearestAncestor const):
* Source/WebCore/accessibility/AccessibilityObject.h:
* Source/WebCore/accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::parentObject const):
* Source/WebCore/accessibility/AccessibilityScrollView.cpp:
(WebCore::AccessibilityScrollView::documentFrameView const):
* Source/WebCore/animation/StyleOriginatedTimelinesController.cpp:
(WebCore::StyleOriginatedTimelinesController::inactiveNamedTimeline):
* Source/WebCore/css/CSSKeyframeRule.cpp:
(WebCore::StyleRuleKeyframe::mutableProperties):
* Source/WebCore/css/CSSPrimitiveValueMappings.h:
(WebCore::TypeDeducingCSSValueMapper::operator const CSSPrimitiveValue& const):
Deleted.
* Source/WebCore/css/ShorthandSerializer.cpp:
(WebCore::ShorthandSerializer::serializeGridTemplate const):
* Source/WebCore/css/StyleRule.cpp:
(WebCore::StyleRule::mutableProperties):
(WebCore::StyleRulePage::mutableProperties):
(WebCore::StyleRuleFontFace::mutableProperties):
* Source/WebCore/dom/CharacterData.cpp:
(WebCore::makeChildChange):
* Source/WebCore/dom/Document.cpp:
(WebCore::Document::takeAnyMediaCanStartListener):
* Source/WebCore/dom/Element.cpp:
(WebCore::Element::ensureUserAgentShadowRoot):
* Source/WebCore/dom/EventPath.h:
(WebCore::EventPath::eventTargetRespectingTargetRules):
* Source/WebCore/editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::composition const):
* Source/WebCore/editing/Editing.cpp:
(WebCore::unsplittableElementForPosition):
* Source/WebCore/editing/Editing.h:
* Source/WebCore/editing/Editor.cpp:
(WebCore::Editor::nodeBeforeWritingSuggestions const):
* Source/WebCore/editing/TextIterator.cpp:
(WebCore::firstNode):
* Source/WebCore/inspector/NetworkResourcesData.cpp:
(WebCore::NetworkResourcesData::ResourceData::decodeDataToContent):
* Source/WebCore/loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::resourceData const):
* Source/WebCore/loader/SubstituteResource.h:
(WebCore::SubstituteResource::deliver):
(WebCore::SubstituteResource::data const): Deleted.
* Source/WebCore/loader/archive/mhtml/MHTMLArchive.cpp:
(WebCore::MHTMLArchive::generateMHTMLData):
* Source/WebCore/loader/archive/mhtml/MHTMLParser.cpp:
(WebCore::MHTMLParser::parseNextPart):
* Source/WebCore/loader/ios/LegacyPreviewLoader.mm:
(WebCore::LegacyPreviewLoader::provideMainResourceForPreviewConverter):
* Source/WebCore/page/FocusController.cpp:
(WebCore::FocusController::focusedOrMainFrame const):
* Source/WebCore/page/LocalFrame.cpp:
(WebCore::LocalFrame::userContentProvider const):
(WebCore::LocalFrame::userContentProvider):
* Source/WebCore/page/Page.cpp:
(WebCore::Page::localMainFrame const):
(WebCore::Page::localTopDocument const):
(WebCore::Page::localMainFrame):
(WebCore::Page::localTopDocument):
* Source/WebCore/page/Page.h:
(WebCore::Page::mainFrame const):
(WebCore::Page::userContentProviderForFrame):
(WebCore::Page::mainFrame): Deleted.
* Source/WebCore/platform/PreviewConverter.cpp:
(WebCore::PreviewConverter::previewData const):
(WebCore::PreviewConverter::replayToClient):
* Source/WebCore/platform/SharedBuffer.cpp:
(WebCore::FragmentedSharedBuffer::fromIPCData):
(WebCore::SharedBufferBuilder::takeBuffer):
(WebCore::SharedBufferBuilder::takeBufferAsContiguous):
(WebCore::SharedBufferBuilder::takeBufferAsArrayBuffer):
(WebCore::SharedBufferBuilder::take): Deleted.
(WebCore::SharedBufferBuilder::takeAsContiguous): Deleted.
(WebCore::SharedBufferBuilder::takeAsArrayBuffer): Deleted.
* Source/WebCore/platform/SharedBuffer.h:
(WebCore::SharedBufferBuilder::protectedBuffer const):
(WebCore::SharedBufferBuilder::copyBuffer const):
(WebCore::SharedBufferBuilder::get const): Deleted.
(WebCore::SharedBufferBuilder::copy const): Deleted.
* Source/WebCore/platform/graphics/MediaResourceSniffer.cpp:
(WebCore::MediaResourceSniffer::dataReceived):
(WebCore::MediaResourceSniffer::loadFinished):
*
Source/WebCore/platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm:
(WebCore::PlatformResourceMediaLoader::dataReceived):
* Source/WebCore/platform/graphics/cocoa/SourceBufferParserWebM.cpp:
(WebCore::WebMParser::TrackData::readFrameData):
* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::parseInitDataFromProtectionMessage):
* Source/WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
(WebCore::readICCProfile):
* Source/WebCore/platform/mediarecorder/MediaRecorderPrivateEncoder.cpp:
(WebCore::MediaRecorderPrivateEncoder::takeData):
* Source/WebCore/platform/mediarecorder/MediaRecorderPrivateGStreamer.cpp:
(WebCore::MediaRecorderPrivateBackend::fetchData):
* Source/WebCore/platform/network/cocoa/RangeResponseGenerator.mm:
(WebCore::RangeResponseGenerator::giveResponseToTaskIfBytesInRangeReceived):
* Source/WebCore/workers/ScriptBuffer.cpp:
(WebCore::ScriptBuffer::toString const):
* Source/WebCore/workers/ScriptBuffer.h:
(WebCore::ScriptBuffer::bufferBuilder const):
(WebCore::ScriptBuffer::buffer const):
(WebCore::ScriptBuffer::protectedBuffer const):
(WebCore::ScriptBuffer::isolatedCopy const):
* Source/WebCore/workers/WorkerFontLoadRequest.cpp:
(WebCore::WorkerFontLoadRequest::ensureCustomFontData):
* Source/WebCore/workers/service/server/SWScriptStorage.cpp:
(WebCore::SWScriptStorage::store):
* Source/WebCore/xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::createResponseBlob):
(WebCore::XMLHttpRequest::createResponseArrayBuffer):
* Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::didFinishLoading):
(WebKit::NetworkResourceLoader::bufferingTimerFired):
(WebKit::NetworkResourceLoader::tryStoreAsCacheEntry):
* Source/WebKit/NetworkProcess/cache/NetworkCacheSpeculativeLoad.cpp:
(WebKit::NetworkCache::SpeculativeLoad::didFinishLoading):
* Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::NetworkSessionCocoa::loadImageForDecoding):
* Source/WebKit/NetworkProcess/storage/BackgroundFetchStoreManager.cpp:
(WebKit::BackgroundFetchStoreManager::retrieveResponseBody):
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:
* Source/WebKit/UIProcess/WebURLSchemeTask.cpp:
(WebKit::WebURLSchemeTask::didComplete):
* Source/WebKit/WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::liveResourceData const):
(WebKit::PluginView::redeliverManualStream):
* Source/WebKit/WebProcess/Storage/WebServiceWorkerFetchTaskClient.cpp:
(WebKit::WebServiceWorkerFetchTaskClient::continueDidReceiveResponse):
* Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.cpp:
(WebKit::WebLocalFrameLoaderClient::dispatchCreatePage):
* Source/WebKit/WebProcess/WebCoreSupport/ios/WebPreviewLoaderClient.cpp:
(WebKit::WebPreviewLoaderClient::didFinishLoading):
* Tools/TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp:
(TestWebKitAPI::TEST_F(FragmentedSharedBufferTest,
appendBufferCreatedWithContentsOfExistingFile)):
(TestWebKitAPI::TEST_F(FragmentedSharedBufferTest, tryCreateArrayBuffer)):
(TestWebKitAPI::TEST_F(FragmentedSharedBufferTest,
contiguousAlwaysStayContiguous)):
(TestWebKitAPI::TEST_F(FragmentedSharedBufferTest, getReturnsContiguous)):
(TestWebKitAPI::TEST_F(FragmentedSharedBufferTest,
tryCreateArrayBufferLargeSegments)):
(TestWebKitAPI::TEST_F(FragmentedSharedBufferTest, copy)):
(TestWebKitAPI::TEST_F(FragmentedSharedBufferTest, builder)):
(TestWebKitAPI::TEST_F(FragmentedSharedBufferTest, builderEmptyFollowedByGet)):
(TestWebKitAPI::TEST_F(FragmentedSharedBufferTest, builderInPlace)):
(TestWebKitAPI::TEST_F(FragmentedSharedBufferTest, getSomeData)):
(TestWebKitAPI::TEST_F(FragmentedSharedBufferTest, getContiguousData)):
(TestWebKitAPI::TEST_F(FragmentedSharedBufferTest, isEqualTo)):
(TestWebKitAPI::TEST_F(FragmentedSharedBufferTest, toHexString)):
(TestWebKitAPI::TEST_F(FragmentedSharedBufferTest, read)):
(TestWebKitAPI::TEST_F(FragmentedSharedBufferTest,
takeDataIsContiguousWhenPossible)):
(TestWebKitAPI::TEST_F(FragmentedSharedBufferTest,
getIsContiguousWhenPossible)):
(TestWebKitAPI::TEST_F(FragmentedSharedBufferTest,
emptySharedBufferBuilderIsContiguous)):
(TestWebKitAPI::TEST_F(SharedBufferChunkReaderTest, includeSeparator)):
(TestWebKitAPI::TEST_F(SharedBufferChunkReaderTest, peekData)):
(TestWebKitAPI::TEST_F(SharedBufferChunkReaderTest,
readAllChunksInMultiSegment)):
* Tools/TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm:
(TestWebKitAPI::TEST_F(FragmentedSharedBufferTest, createNSDataArray)):
(TestWebKitAPI::TEST_F(FragmentedSharedBufferTest, createNSDataForDataSegment)):
Canonical link: https://commits.webkit.org/303790@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
