Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: b27b976f24798e6d23bd2efe9be34ccff918b034
https://github.com/WebKit/WebKit/commit/b27b976f24798e6d23bd2efe9be34ccff918b034
Author: Qianlang Chen <[email protected]>
Date: 2025-12-02 (Tue, 02 Dec 2025)
Changed paths:
M Source/WebKit/Sources.txt
M Source/WebKit/UIProcess/Inspector/WebPageInspectorTargetProxy.cpp
M Source/WebKit/WebKit.xcodeproj/project.pbxproj
R Source/WebKit/WebProcess/Inspector/WebPageInspectorTargetController.cpp
R Source/WebKit/WebProcess/Inspector/WebPageInspectorTargetController.h
M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
M Source/WebKit/WebProcess/WebPage/WebPage.h
M Source/WebKit/WebProcess/WebPage/WebPage.messages.in
Log Message:
-----------
Web Inspector: Remove the trivial WebPageInspectorTargetController class
rdar://165175864
https://bugs.webkit.org/show_bug.cgi?id=302912
Reviewed by Basuke Suzuki.
The WebPageInspectorTargetController in the web process looks like it
was designed to handle multiple inspection targets existing in one web
process, but it ended up only ever having one, the WebCore page. We have
no plan to actually make this controller handle any other targets, and
any additional targets (like frame) is handled in the UI process by the
webpage target / WebPageInspectorController and its target agent.
Thus, we should remove it to simplify our architecture.
No new tests: no expected change in noticeable behavior.
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::ensureInspectorTarget):
(WebKit::WebPage::connectInspector):
(WebKit::WebPage::disconnectInspector):
(WebKit::WebPage::sendMessageToTargetBackend):
* Source/WebKit/WebProcess/WebPage/WebPage.h:
* Source/WebKit/WebProcess/WebPage/WebPage.messages.in:
* Source/WebKit/UIProcess/Inspector/WebPageInspectorTargetProxy.cpp:
(WebKit::WebPageInspectorTargetProxy::connect):
(WebKit::WebPageInspectorTargetProxy::disconnect):
(WebKit::WebPageInspectorTargetProxy::sendMessageToTargetBackend):
- Remove the unused targetId argument as it's now clear that there's
only one page target to refer to.
* Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp:
- Fix build error due to unified source changes.
* Source/WebKit/Sources.txt:
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Source/WebKit/WebProcess/Inspector/WebPageInspectorTargetController.cpp:
Removed.
* Source/WebKit/WebProcess/Inspector/WebPageInspectorTargetController.h:
Removed.
Canonical link: https://commits.webkit.org/303762@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
