Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 9a360b05516c7b4d17bf93a5cacb8d38dfc26f62
https://github.com/WebKit/WebKit/commit/9a360b05516c7b4d17bf93a5cacb8d38dfc26f62
Author: Alan Baradlay <[email protected]>
Date: 2025-12-02 (Tue, 02 Dec 2025)
Changed paths:
A LayoutTests/fast/inline/minmax-content-confusion-assert-expected.txt
A LayoutTests/fast/inline/minmax-content-confusion-assert.html
M Source/WebCore/layout/formattingContexts/inline/IntrinsicWidthHandler.cpp
Log Message:
-----------
ASSERT(contentHasNegativeImplicitMargin) hits in
InlineFormattingContext::minimumMaximumContentSize
https://bugs.webkit.org/show_bug.cgi?id=303391
Reviewed by Antti Koivisto.
Use InlineLayoutUnit (float) instead of LayoutUnit to hold infinite available
space
for IntrinsicWidthMode::Maximum computation.
It ensures that computed content always "fits" the available space.
(while with LayoutUnit's narrower value range, content
may "overflow" and as the result we end up breaking it into multiple lines even
when
available space is supposed to be infinite. Alternatively we could teach line
builders
to recognize std::optional<> available space.)
Test: fast/inline/minmax-content-confusion-assert.html
* LayoutTests/fast/inline/minmax-content-confusion-assert-expected.txt: Added.
* LayoutTests/fast/inline/minmax-content-confusion-assert.html: Added.
* Source/WebCore/layout/formattingContexts/inline/IntrinsicWidthHandler.cpp:
(WebCore::Layout::IntrinsicWidthHandler::computedIntrinsicWidthForConstraint):
Canonical link: https://commits.webkit.org/303761@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
