Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: b4952badb66f20d73d9b3ac12b36e131f6bc2d65
https://github.com/WebKit/WebKit/commit/b4952badb66f20d73d9b3ac12b36e131f6bc2d65
Author: Chris Dumez <[email protected]>
Date: 2025-12-01 (Mon, 01 Dec 2025)
Changed paths:
M Source/WTF/wtf/RetainPtr.h
M Source/WebCore/editing/cocoa/AlternativeTextContextController.mm
M Source/WebCore/editing/cocoa/AttributedString.mm
M Source/WebCore/page/cocoa/DataDetectionResultsStorage.h
M Source/WebCore/platform/graphics/Icon.h
M Source/WebCore/platform/text/cocoa/LocalizedDateCache.mm
M Source/WebCore/rendering/mac/RenderThemeMac.mm
M Source/WebKit/Platform/classifier/cocoa/TextExtractionFilter.mm
M Source/WebKit/Platform/cocoa/CocoaHelpers.h
M Source/WebKit/Shared/WebBackForwardListFrameItem.cpp
M Source/WebKit/Shared/WebBackForwardListFrameItem.h
M Source/WebKit/Shared/WebBackForwardListItem.cpp
M Source/WebKit/UIProcess/API/APIFrameInfo.cpp
M Source/WebKit/UIProcess/API/APIScriptMessage.h
M Source/WebKit/UIProcess/API/Cocoa/WKDownload.mm
M Source/WebKit/UIProcess/API/Cocoa/WKScriptMessage.mm
M Source/WebKit/UIProcess/API/Cocoa/_WKDataTask.mm
M Source/WebKit/UIProcess/API/Cocoa/_WKInspector.mm
M Source/WebKit/UIProcess/API/Cocoa/_WKWebPushMessage.mm
M Source/WebKit/UIProcess/API/Cocoa/_WKWebPushSubscriptionData.mm
M Source/WebKit/UIProcess/ApplicationStateTracker.mm
M Source/WebKit/UIProcess/Cocoa/ModelElementControllerCocoa.mm
M Source/WebKit/UIProcess/Cocoa/WKShareSheet.mm
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm
M Source/WebKit/UIProcess/WebBackForwardList.cpp
M Source/WebKit/UIProcess/WebFrameProxy.cpp
M Source/WebKit/UIProcess/WebFrameProxy.h
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebPageProxy.h
M Source/WebKit/UIProcess/ios/DragDropInteractionState.mm
M Source/WebKit/UIProcess/ios/WKHighlightLongPressGestureRecognizer.mm
M Source/WebKit/UIProcess/ios/WKScrollView.mm
M Source/WebKit/UIProcess/ios/WKTextInteractionWrapper.mm
M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm
M Source/WebKit/UIProcess/mac/WebViewImpl.mm
M Source/WebKit/webpushd/_WKMockUserNotificationCenter.mm
M
Source/WebKitLegacy/SaferCPPExpectations/UnretainedLocalVarsCheckerExpectations
M Source/WebKitLegacy/mac/History/WebHistory.mm
M Source/WebKitLegacy/mac/WebCoreSupport/WebInspectorClient.mm
M Source/WebKitLegacy/mac/WebCoreSupport/WebNotificationClient.mm
M Source/WebKitLegacy/mac/WebView/WebView.mm
M Tools/DumpRenderTree/mac/DumpRenderTreePasteboard.mm
M Tools/DumpRenderTree/mac/MockWebNotificationProvider.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm
Log Message:
-----------
Reduce use of `unsafeGet()` in WebKit/
https://bugs.webkit.org/show_bug.cgi?id=303122
Reviewed by Timothy Hatcher and Darin Adler.
Part of it was tweaking the HashTraits for RetainPtr to use
a `P*` as PeekType instead of a `RetainPtr<P>`, similarly to
what we do for `RefPtr<P>`.
* Source/WTF/wtf/RetainPtr.h:
(WTF::HashTraits<RetainPtr<P>>::emptyValue):
(WTF::HashTraits<RetainPtr<P>>::isEmptyValue):
(WTF::HashTraits<RetainPtr<P>>::peek):
* Source/WebCore/editing/cocoa/AlternativeTextContextController.mm:
(WebCore::AlternativeTextContextController::alternativesForContext const):
* Source/WebCore/editing/cocoa/AttributedString.mm:
(WebCore::reconstructStyle):
* Source/WebCore/page/cocoa/DataDetectionResultsStorage.h:
(WebCore::DataDetectionResultsStorage::imageOverlayDataDetectionResult):
* Source/WebCore/platform/graphics/Icon.h:
(WebCore::Icon::image const):
* Source/WebCore/platform/text/cocoa/LocalizedDateCache.mm:
(WebCore::LocalizedDateCache::formatterForDateType):
* Source/WebCore/rendering/mac/RenderThemeMac.mm:
(WebCore::RenderThemeMac::iconForAttachment):
* Source/WebKit/Platform/classifier/cocoa/TextExtractionFilter.mm:
(WebKit::TextExtractionFilter::singleton):
* Source/WebKit/Platform/cocoa/CocoaHelpers.h:
(WebKit::toCocoaImage):
* Source/WebKit/Shared/WebBackForwardListFrameItem.cpp:
(WebKit::WebBackForwardListFrameItem::rootFrame):
(WebKit::WebBackForwardListFrameItem::mainFrame):
* Source/WebKit/Shared/WebBackForwardListFrameItem.h:
* Source/WebKit/Shared/WebBackForwardListItem.cpp:
(WebKit::WebBackForwardListItem::navigatedFrameItem const):
* Source/WebKit/UIProcess/API/APIFrameInfo.cpp:
(API::FrameInfo::page const):
(API::FrameInfo::page):
* Source/WebKit/UIProcess/API/APIScriptMessage.h:
* Source/WebKit/UIProcess/API/Cocoa/WKDownload.mm:
(-[WKDownload delegate]):
* Source/WebKit/UIProcess/API/Cocoa/WKScriptMessage.mm:
(-[WKScriptMessage name]):
* Source/WebKit/UIProcess/API/Cocoa/_WKDataTask.mm:
(-[_WKDataTask webView]):
* Source/WebKit/UIProcess/API/Cocoa/_WKInspector.mm:
(-[_WKInspector delegate]):
* Source/WebKit/UIProcess/API/Cocoa/_WKWebPushMessage.mm:
(-[_WKWebPushMessage data]):
* Source/WebKit/UIProcess/API/Cocoa/_WKWebPushSubscriptionData.mm:
(-[_WKWebPushSubscriptionData applicationServerKey]):
(-[_WKWebPushSubscriptionData authenticationSecret]):
(-[_WKWebPushSubscriptionData ecdhPublicKey]):
* Source/WebKit/UIProcess/ApplicationStateTracker.mm:
(WebKit::ApplicationStateTracker::setWindow):
* Source/WebKit/UIProcess/Cocoa/ModelElementControllerCocoa.mm:
(WebKit::ModelElementController::previewForModelIdentifier):
* Source/WebKit/UIProcess/Cocoa/WKShareSheet.mm:
(-[WKShareSheet delegate]):
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm:
(WebKit::WebExtension::bestIcon):
(WebKit::WebExtension::bestIconVariant):
* Source/WebKit/UIProcess/WebBackForwardList.cpp:
(WebKit::WebBackForwardList::itemForID):
* Source/WebKit/UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::traversePrevious):
(WebKit::WebFrameProxy::deepLastChild):
* Source/WebKit/UIProcess/WebFrameProxy.h:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::fromIdentifier):
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/ios/DragDropInteractionState.mm:
(WebKit::DragDropInteractionState::defaultDropPreview const):
(WebKit::DragDropInteractionState::finalDropPreview const):
* Source/WebKit/UIProcess/ios/WKHighlightLongPressGestureRecognizer.mm:
(-[WKHighlightLongPressGestureRecognizer lastTouchedScrollView]):
* Source/WebKit/UIProcess/ios/WKScrollView.mm:
(-[WKScrollView _wk_topEdgeEffect]):
(-[WKScrollView _wk_leftEdgeEffect]):
(-[WKScrollView _wk_rightEdgeEffect]):
(-[WKScrollView _wk_bottomEdgeEffect]):
* Source/WebKit/UIProcess/ios/WKTextInteractionWrapper.mm:
(-[WKTextInteractionWrapper textSelectionDisplayInteraction]):
(-[WKTextInteractionWrapper prepareToMoveSelectionContainer:]):
* Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm:
(-[WKFullScreenViewController delegate]):
* Source/WebKit/UIProcess/mac/WebViewImpl.mm:
(WebKit::WebViewImpl::createPDFHUD):
(WebKit::WebViewImpl::updatePDFHUDLocation):
(WebKit::WebViewImpl::removePDFHUD):
* Source/WebKit/webpushd/_WKMockUserNotificationCenter.mm:
(-[_WKMockUserNotificationCenter notificationSettings]):
*
Source/WebKitLegacy/SaferCPPExpectations/UnretainedLocalVarsCheckerExpectations:
* Source/WebKitLegacy/mac/History/WebHistory.mm:
(-[WebHistoryPrivate insertItem:forDateKey:]):
(-[WebHistoryPrivate orderedItemsLastVisitedOnDay:]):
(WebHistoryWriter::writeHistoryItems):
* Source/WebKitLegacy/mac/WebCoreSupport/WebInspectorClient.mm:
(WebInspectorFrontendClient::save):
* Source/WebKitLegacy/mac/WebCoreSupport/WebNotificationClient.mm:
(WebNotificationClient::cancel):
* Source/WebKitLegacy/mac/WebView/WebView.mm:
(-[WebView _objectForIdentifier:]):
* Tools/DumpRenderTree/mac/DumpRenderTreePasteboard.mm:
(-[LocalPasteboard dataForType:]):
* Tools/DumpRenderTree/mac/MockWebNotificationProvider.mm:
(-[MockWebNotificationProvider webView:didShowNotification:]):
(-[MockWebNotificationProvider webView:didClickNotification:]):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
(-[PSONScheme webView:startURLSchemeTask:]):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
(-[ServiceWorkerSchemeHandler webView:startURLSchemeTask:]):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
(-[DataMappingSchemeHandler webView:startURLSchemeTask:]):
Canonical link: https://commits.webkit.org/303705@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
