Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 01cbd4c60cd2d5b40c1733fa82c1da7a76cee93c
https://github.com/WebKit/WebKit/commit/01cbd4c60cd2d5b40c1733fa82c1da7a76cee93c
Author: Adrian Taylor <[email protected]>
Date: 2025-11-25 (Tue, 25 Nov 2025)
Changed paths:
M Configurations/CommonBase.xcconfig
M Source/WebKit/Configurations/Base.xcconfig
M Source/WebKit/Configurations/BaseExtension.xcconfig
M Source/WebKit/_WebKit_SwiftUI/Implementation/CocoaWebViewAdapter.swift
M Source/WebKit/_WebKit_SwiftUI/Implementation/WebViewRepresentable.swift
Log Message:
-----------
Enforce strict memory safety across WebKit
https://bugs.webkit.org/show_bug.cgi?id=300439
rdar://162275605
Reviewed by Elliott Williams.
Other WebKit configuration files promote some (few) classes of Swift warnings
to errors. These errors were being suppressed in some cases; this removes that
suppression.
The only class of warning being promoted to error is the strict memory safety
warnings; these become errors. This PR therefore also fixes the remaining
strict memory safety issues.
This is the fourth attempt at removing this suppression. The first attempt
caused trouble due to these safety errors which did not show up on the EWS bots
in use at the time. EWS is now building using SDK versions which should
correctly show up any remaining problems. The second attempt failed because
VisionOS has some remaining code that does not comply with strict memory
safety; the bug numbers for fixing that are mentioned in a comment. The
third attempt failed due to two builders still lacking some toolchain fixes
and new problematic code being turned on.
It is worth noting that PAL.xcconfig still overrides the
OTHER_SWIFT_FLAGS variable and thus does not get the benefit of thesse safety
errors. That's intentional, because PAL still has some strict safety problems
to be resolved, tracked in rdar://164560176.
* Configurations/CommonBase.xcconfig:
* Source/WebKit/Configurations/Base.xcconfig:
* Source/WebKit/Configurations/BaseExtension.xcconfig:
* Source/WebKit/_WebKit_SwiftUI/Implementation/CocoaWebViewAdapter.swift:
(CocoaWebViewAdapter.findInteraction):
(CocoaWebViewAdapter.findBarDidBecomeHidden):
(CocoaWebViewAdapter.webView):
* Source/WebKit/_WebKit_SwiftUI/Implementation/WebViewRepresentable.swift:
Canonical link: https://commits.webkit.org/303537@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
