Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 07e87d550ef2eccca07a0dc80b721ff0907e40a2
https://github.com/WebKit/WebKit/commit/07e87d550ef2eccca07a0dc80b721ff0907e40a2
Author: Antoine Quint <[email protected]>
Date: 2025-11-22 (Sat, 22 Nov 2025)
Changed paths:
A
LayoutTests/webanimations/threaded-animations/transform-animation-extent-crash-expected.txt
A
LayoutTests/webanimations/threaded-animations/transform-animation-extent-crash.html
Log Message:
-----------
[threaded-animations]
https://scroll-driven-animations.style/demos/contact-list/css/ asserts with
"Threaded Scroll-driven Animations" enabled
https://bugs.webkit.org/show_bug.cgi?id=302940
rdar://165207414
Reviewed by Alan Baradlay.
In 303045@main we updated our transform animation extent computation code to
iterate over
an effect's keyframes to compute their respective animated style and build up
the bounds
union for all keyframes. However, in the case of scroll-driven animations, we
could hit
`ASSERT(computedTiming.progress)` under
`KeyframeEffect::setAnimatedPropertiesInStyle()`
because the keyframe's offset may not have been computed for view timelines
using one of
view timeline range keywords [0].
This issue was actually already fixed in 303410@main by ensuring we don't
accelerate
pending animations [1], but we add a test that would have caught this
particular assertion
being hit.
[0] https://drafts.csswg.org/scroll-animations-1/#view-timelines-ranges
[1] https://drafts.csswg.org/web-animations-1/#dom-animation-pending
Test: webanimations/threaded-animations/transform-animation-extent-crash.html
*
LayoutTests/webanimations/threaded-animations/transform-animation-extent-crash-expected.txt:
Added.
*
LayoutTests/webanimations/threaded-animations/transform-animation-extent-crash.html:
Added.
Canonical link: https://commits.webkit.org/303443@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
