Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 2da497c2bd9564a6af07c9583ae489c7eda04078
https://github.com/WebKit/WebKit/commit/2da497c2bd9564a6af07c9583ae489c7eda04078
Author: Antti Koivisto <[email protected]>
Date: 2025-11-17 (Mon, 17 Nov 2025)
Changed paths:
M
LayoutTests/fast/inline/blocks-in-inline-margin-collapse-float-expected.html
M LayoutTests/fast/inline/blocks-in-inline-margin-collapse-float.html
A LayoutTests/fast/inline/blocks-in-inline-multicol-widows-expected.html
A LayoutTests/fast/inline/blocks-in-inline-multicol-widows.html
M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp
Log Message:
-----------
[blocks-in-inline] Stop updating block render tree positions
LineLayout::updateRenderTreePositions
https://bugs.webkit.org/show_bug.cgi?id=302633
rdar://164875829
Reviewed by Alan Baradlay.
We compute the positions during nested layout. Another round of positioning is
just chance to get things
wrong and hide bugs.
Test: fast/inline/blocks-in-inline-multicol-widows.html
* LayoutTests/fast/inline/blocks-in-inline-margin-collapse-float-expected.html:
* LayoutTests/fast/inline/blocks-in-inline-margin-collapse-float.html:
There was a hidden bug with this test. Update the test to not hit it for now as
we will implement
proper margin collapsing separately.
* LayoutTests/fast/inline/blocks-in-inline-multicol-widows-expected.html: Added.
* LayoutTests/fast/inline/blocks-in-inline-multicol-widows.html: Added.
Here we got position right and then updateRenderTreePositions moved the box to
a wrong place.
* Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::updateRenderTreePositions):
Stop updating block positions.
Canonical link: https://commits.webkit.org/303117@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
