Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 7e06217e94fc417d31966f133ac562fd18293359
https://github.com/WebKit/WebKit/commit/7e06217e94fc417d31966f133ac562fd18293359
Author: Alan Baradlay <[email protected]>
Date: 2025-11-13 (Thu, 13 Nov 2025)
Changed paths:
A LayoutTests/fast/inline/incorrect-pre-offset-expected.txt
A LayoutTests/fast/inline/incorrect-pre-offset.html
M LayoutTests/platform/ios/css3/unicode-bidi-float-crash-expected.txt
M
LayoutTests/platform/ios/fast/block/positioning/rtl-static-positioning-expected.txt
M
LayoutTests/platform/ios/fast/block/positioning/table-cell-static-position-expected.txt
M LayoutTests/platform/mac/css3/unicode-bidi-float-crash-expected.txt
M
LayoutTests/platform/mac/fast/block/positioning/rtl-static-positioning-expected.txt
M
LayoutTests/platform/mac/fast/block/positioning/table-cell-static-position-expected.txt
M
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayLine.h
M
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayLineBuilder.cpp
M
Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContent.cpp
M Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContent.h
M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp
Log Message:
-----------
[IFC] Add hasInflowContent() to InlineDisplay::Line
https://bugs.webkit.org/show_bug.cgi?id=302478
Reviewed by Antti Koivisto.
Instead of relying on the number of display boxes on the line, let's add
a bit to Line indicating whether it has any inflow content.
This is relevant only when the line has only empty inline(s) -with no
decoration.
This change enables us to generate such (display) inline boxes and still report
the
line as empty (see webkit.org/b/302442).
(This change also a slight change in functionality (progression) as now we
start reporting empty
lines -see tree dump changes/layout test )
* LayoutTests/fast/inline/incorrect-pre-offset-expected.txt: Added.
* LayoutTests/fast/inline/incorrect-pre-offset.html: Added.
* LayoutTests/platform/ios/css3/unicode-bidi-float-crash-expected.txt:
*
LayoutTests/platform/ios/fast/block/positioning/rtl-static-positioning-expected.txt:
*
LayoutTests/platform/ios/fast/block/positioning/table-cell-static-position-expected.txt:
* LayoutTests/platform/mac/css3/unicode-bidi-float-crash-expected.txt:
*
LayoutTests/platform/mac/fast/block/positioning/rtl-static-positioning-expected.txt:
*
LayoutTests/platform/mac/fast/block/positioning/table-cell-static-position-expected.txt:
* Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayLine.h:
(WebCore::InlineDisplay::Line::hasInflowContent const):
(WebCore::InlineDisplay::Line::Line):
*
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayLineBuilder.cpp:
(WebCore::Layout::InlineDisplayLineBuilder::build const):
* Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContent.cpp:
(WebCore::LayoutIntegration::InlineContent::hasInflowContent const):
(WebCore::LayoutIntegration::InlineContent::hasContent const): Deleted.
* Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContent.h:
* Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::lastLineWithInlineContent):
(WebCore::LayoutIntegration::LineLayout::hasEllipsisInBlockDirectionOnLastFormattedLine
const):
(WebCore::LayoutIntegration::LineLayout::lineCount const):
(WebCore::LayoutIntegration::LineLayout::firstRootInlineBox const):
(WebCore::LayoutIntegration::LineLayout::firstLineBox const):
(WebCore::LayoutIntegration::LineLayout::lastLineBox const):
(WebCore::LayoutIntegration::LineLayout::enclosingBorderBoxRectFor const):
Canonical link: https://commits.webkit.org/303025@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
