Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: bbf8d7c49cc111a761a9365b53daec5cfece2bee
https://github.com/WebKit/WebKit/commit/bbf8d7c49cc111a761a9365b53daec5cfece2bee
Author: Antti Koivisto <[email protected]>
Date: 2025-11-12 (Wed, 12 Nov 2025)
Changed paths:
A LayoutTests/fast/css/user-stylesheet-rollback-expected.txt
A LayoutTests/fast/css/user-stylesheet-rollback.html
M Source/WebCore/style/StyleBuilder.cpp
M Source/WebCore/style/StyleBuilder.h
Log Message:
-----------
REGRESSION(299900@main): Crash in
Style::Builder::ensureRollbackCascadeForRevert() with user stylesheet
https://bugs.webkit.org/show_bug.cgi?id=302386
rdar://164300744
Reviewed by Kimmo Kinnunen.
Test: fast/css/user-stylesheet-rollback.html
* LayoutTests/fast/css/user-stylesheet-rollback-expected.txt: Added.
* LayoutTests/fast/css/user-stylesheet-rollback.html: Added.
* Source/WebCore/style/StyleBuilder.cpp:
(WebCore::Style::Builder::makeRollbackCascadeKey):
299900@main changes enums so that value PropertyCascade::Origin::UserAgent is
zero.
This caused RollbackCascadeKey's empty value (all zeros) collide with a legal
value.
Fix by adding an extra bool to the key which is always set on legal values.
* Source/WebCore/style/StyleBuilder.h:
Canonical link: https://commits.webkit.org/302903@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
