Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 104bb9f0be1fa1dd2b22950acc3e50c06ead5783
https://github.com/WebKit/WebKit/commit/104bb9f0be1fa1dd2b22950acc3e50c06ead5783
Author: Fujii Hironori <[email protected]>
Date: 2025-11-11 (Tue, 11 Nov 2025)
Changed paths:
M
LayoutTests/imported/w3c/web-platform-tests/webxr/hit-test/ar_hittest_subscription_states_regular.https-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/webxr/hit-test/ar_hittest_subscription_states_regular.https.html
Log Message:
-----------
[WPT][WebXR Hit Test] the promise test in
webxr/hit-test/ar_hittest_subscription_states_regular.https.html doesn't work
as expected
https://bugs.webkit.org/show_bug.cgi?id=302330
Reviewed by Dan Glastonbury.
In this test case, both requestReferenceSpace and requestHitTestSource return a
promise. These promises should be chained properly by using `then` like the
following code.
session.requestReferenceSpace(...).then(refSpace => {
...
return session.requestHitTestSource(...);
}).then(hitTestSource => {
...
})
However, the second promise was not chained, but using the second `then` inside
the first `then`.
session.requestReferenceSpace(...).then(refSpace => {
...
return session.requestHitTestSource(...).then(hitTestSource => {
...
});
})
This code doesn't wait the second promise to be settled.
Rather than using promises chaining, this change rewrote the test using
async&await. This change should be exported to the upstream WPT.
After this change, this test starts to fail as expected due to a existing bug
<https://webkit.org/b/302322>.
*
LayoutTests/imported/w3c/web-platform-tests/webxr/hit-test/ar_hittest_subscription_states_regular.https-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/webxr/hit-test/ar_hittest_subscription_states_regular.https.html:
Canonical link: https://commits.webkit.org/302876@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
