Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ad3158dabf2908917211190483eed9965bb81a95
https://github.com/WebKit/WebKit/commit/ad3158dabf2908917211190483eed9965bb81a95
Author: Jer Noble <[email protected]>
Date: 2025-11-11 (Tue, 11 Nov 2025)
Changed paths:
M Source/WebCore/page/Page.cpp
M Tools/TestWebKitAPI/Tests/mac/InWindowFullscreen.mm
M Tools/TestWebKitAPI/cocoa/TestWKWebView.h
M Tools/TestWebKitAPI/cocoa/TestWKWebView.mm
Log Message:
-----------
[macOS] Video Viewer mode fails for iframe videos
https://bugs.webkit.org/show_bug.cgi?id=302287
rdar://164037725
Reviewed by Eric Carlson.
Restore the ability for videos in an iframe to enter Video Viewer mode. The
search criteria for the "bestMediaElementForRemoteControls" should be every
document within the page, and not just the main frame's document.
Tests: Tools/TestWebKitAPI/Tests/mac/InWindowFullscreen.mm
* Source/WebCore/page/Page.cpp:
(WebCore::Page::playbackControlsManagerUpdateTimerFired):
* Tools/TestWebKitAPI/Tests/mac/InWindowFullscreen.mm:
(TestWebKitAPI::TEST(InWindowFullscreen, IFrameDocument)):
* Tools/TestWebKitAPI/cocoa/TestWKWebView.h:
* Tools/TestWebKitAPI/cocoa/TestWKWebView.mm:
(-[WKWebView objectByEvaluatingJavaScriptWithUserGesture:inFrame:]):
Canonical link: https://commits.webkit.org/302842@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
