Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 41e5dc72070c00177587df53e0a660498e17653d
https://github.com/WebKit/WebKit/commit/41e5dc72070c00177587df53e0a660498e17653d
Author: Megan Gardner <[email protected]>
Date: 2025-11-10 (Mon, 10 Nov 2025)
Changed paths:
M Source/WebCore/page/cocoa/WebTextIndicatorLayer.h
M Source/WebCore/page/cocoa/WebTextIndicatorLayer.mm
M Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm
M Source/WebKitLegacy/mac/WebCoreSupport/TextIndicatorWindow.mm
Log Message:
-----------
Fix ref churn and conform to safer CPP guidelines for updateWithFrame.
https://bugs.webkit.org/show_bug.cgi?id=302229
rdar://164373056
Reviewed by Wenson Hsieh.
It was pointed out in the review for 302681@main
that we had some unneeded ref churn in passing a RefPtr
unnecessarily. Looking into updating this also found a
situation in which we needed to conform to our safer CPP
practices in passing member variables.
* Source/WebCore/page/cocoa/WebTextIndicatorLayer.h:
* Source/WebCore/page/cocoa/WebTextIndicatorLayer.mm:
(-[WebTextIndicatorLayer
updateWithFrame:textIndicator:margin:offset:updatingIndicator:]):
(-[WebTextIndicatorLayer initWithFrame:textIndicator:margin:offset:]):
* Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::updateTextIndicator):
* Source/WebKitLegacy/mac/WebCoreSupport/TextIndicatorWindow.mm:
(TextIndicatorWindow::updateTextIndicator):
Canonical link: https://commits.webkit.org/302793@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
