Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: cbd4da15ac4adaaa94a11afc1337a0d8aa9b1f92
https://github.com/WebKit/WebKit/commit/cbd4da15ac4adaaa94a11afc1337a0d8aa9b1f92
Author: Jean-Yves Avenard <[email protected]>
Date: 2025-11-09 (Sun, 09 Nov 2025)
Changed paths:
M
Source/WebCore/platform/mediarecorder/cocoa/MediaRecorderPrivateWriterAVFObjC.h
M
Source/WebCore/platform/mediarecorder/cocoa/MediaRecorderPrivateWriterAVFObjC.mm
Log Message:
-----------
Crash: com.apple.WebKit.WebContent at AVFCore: -[AVAssetWriterInputHelper
requestMediaDataWhenReadyOnQueue:usingBlock:]
https://bugs.webkit.org/show_bug.cgi?id=302226
rdar://164271457
Reviewed by Youenn Fablet and Eric Carlson.
Don't attempt to write to the AVAssetWriter when closing when an error occurred.
>From the documentation "Before calling this method, you must ensure that the
>receiver is attached to an AVAssetWriter via a prior call to -addInput: and
>that -startWriting has been called on the asset writer."
so also add handling to ignore any remaining samples if it's not possible to
use the writer any longer.
*
Source/WebCore/platform/mediarecorder/cocoa/MediaRecorderPrivateWriterAVFObjC.h:
*
Source/WebCore/platform/mediarecorder/cocoa/MediaRecorderPrivateWriterAVFObjC.mm:
(WebCore::MediaRecorderPrivateWriterAVFObjC::addAudioTrack):
(WebCore::MediaRecorderPrivateWriterAVFObjC::addVideoTrack):
(WebCore::MediaRecorderPrivateWriterAVFObjC::allTracksAdded):
(WebCore::MediaRecorderPrivateWriterAVFObjC::close):
Canonical link: https://commits.webkit.org/302779@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
