Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 513e0c0df2670f83c2b99a1765f22460f5a5e2b4
https://github.com/WebKit/WebKit/commit/513e0c0df2670f83c2b99a1765f22460f5a5e2b4
Author: Ben Schwartz <[email protected]>
Date: 2025-11-07 (Fri, 07 Nov 2025)
Changed paths:
M Tools/CISupport/build-webkit-org/factories.py
M Tools/CISupport/build-webkit-org/steps.py
M Tools/CISupport/ews-build/steps.py
M Websites/webkit.org/wp-content/themes/webkit/build-archives.php
Log Message:
-----------
REGRESSION (302748@main): Buildbot queues failing to compile WebKit.
https://bugs.webkit.org/show_bug.cgi?id=302184
rdar://164284543
Reviewed by Brianna Fan.
Since the `architectures` property is passed directly into the `compile-webkit`
step in buildbot, changing the join character to a dash instead of a space
broke invocation of `build-webkit`.
This PR changes that behavior such that we only use the dash when uploading.
* Tools/CISupport/build-webkit-org/factories.py:
(__init__): Change back to using space to join architectures.
* Tools/CISupport/build-webkit-org/steps.py:
(ConfigureBuild.run): Add new property `archForUpload` that has the correct
pattern for uploads.
(CompileWebKit):
-> (follow_up_steps): Change to using the new `archForUpload` property
to craft upload link.
-> (evaluateCommand): Ditto.
(TestMiniBrowserBundle.run): Ditto.
(RunJavaScriptCoreTests.run): Ditto.
(RunTest262Tests.run): Ditto.
(RunWebKitTests.evaluateCommand): Ditto.
(RunAPITests.run): Ditto.
(RunWebDriverTests.run): Ditto.
(ScanBuild.run): Ditto.
* Tools/CISupport/ews-build/steps.py:
(__init__): Change back to using space to join architectures.
(ConfigureBuild.run): Add new property `archForUpload` that has the correct
pattern for uploads.
(CompileWebKit):
-> (follow_up_steps): Change to using the new `archForUpload` property
to craft upload link.
-> (evaluateCommand): Ditto.
(RunJavaScriptCoreTests.evaluateCommand): Ditto.
(RunWebKitTests.evaluateCommand): Ditto.
(RunWebKitTestsInStressMode.evaluateCommand): Ditto.
(ReRunWebKitTests.evaluateCommand): Ditto.
(RunWebKitTestsWithoutChange.evaluateCommand): Ditto.
(RunWebKitTestsRedTree.evaluateCommand): Ditto.
(RunWebKitTestsRepeatFailuresRedTree.evaluateCommand): Ditto.
(RunWebKitTestsRepeatFailuresWithoutChangeRedTree.evaluateCommand): Ditto.
(RunWebKitTestsWithoutChangeRedTree.evaluateCommand): Ditto.
(RunAPITests.run): Ditto.
(ScanBuild.uploadLogsSteps): Ditto.
* Websites/webkit.org/wp-content/themes/webkit/build-archives.php: Drive-by fix
for incorrect static variable reference.
Canonical link: https://commits.webkit.org/302754@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
