Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 3fc022cc4bb9ec5be2fd8a22bfe2798678c59160
https://github.com/WebKit/WebKit/commit/3fc022cc4bb9ec5be2fd8a22bfe2798678c59160
Author: Antoine Quint <[email protected]>
Date: 2025-11-06 (Thu, 06 Nov 2025)
Changed paths:
M
LayoutTests/webanimations/threaded-animations/scroll-driven-animations.html
A
LayoutTests/webanimations/threaded-animations/scroll-timeline-nested-scroller-expected.txt
A
LayoutTests/webanimations/threaded-animations/scroll-timeline-nested-scroller.html
A
LayoutTests/webanimations/threaded-animations/scroll-timeline-root-scroller-expected.txt
A
LayoutTests/webanimations/threaded-animations/scroll-timeline-root-scroller.html
A LayoutTests/webanimations/threaded-animations/threaded-animations-utils.js
M
Source/WebKit/UIProcess/RemoteLayerTree/RemoteProgressBasedTimelineRegistry.cpp
M
Source/WebKit/UIProcess/RemoteLayerTree/RemoteProgressBasedTimelineRegistry.h
M Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.h
M Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingTree.cpp
M Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingTree.h
M
Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteScrollingCoordinatorProxyIOS.h
M
Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteScrollingCoordinatorProxyIOS.mm
M Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteScrollingTreeIOS.cpp
M
Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteLayerTreeEventDispatcher.mm
M Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteScrollingTreeMac.mm
Log Message:
-----------
[threaded-animations] add support for scroll timelines
https://bugs.webkit.org/show_bug.cgi?id=299804
rdar://161579685
Reviewed by Matt Woodrow.
After foundational work done throughout 301942@main, 302029@main, 302282@main,
302580@main and 302634@main, we all the necessary data to represent
scroll-driven
animations and their associated progress-based timelines in the remote layer
tree.
The final piece of the puzzle is to now update progress-based timelines when
a scrolling tree node is scrolled, starting under the platform-specific
implementations of `RemoteScrollingTree::scrollingTreeNodeDidScroll()`.
Once progress-based timelines are updated, we make sure to schedule a rendering
update for the relevant animations.
To make sure this works, we add two new basic tests that scroll a root and a
nested scroller and check the timeline time in the remote layer tree is updated.
Note that this patch fails to make keyboard-originated scrolls work, this will
be addressed in a subsequent patch.
Tests: webanimations/threaded-animations/scroll-timeline-nested-scroller.html
webanimations/threaded-animations/scroll-timeline-root-scroller.html
* LayoutTests/webanimations/threaded-animations/scroll-driven-animations.html:
*
LayoutTests/webanimations/threaded-animations/scroll-timeline-nested-scroller-expected.txt:
Added.
*
LayoutTests/webanimations/threaded-animations/scroll-timeline-nested-scroller.html:
Added.
*
LayoutTests/webanimations/threaded-animations/scroll-timeline-root-scroller-expected.txt:
Added.
*
LayoutTests/webanimations/threaded-animations/scroll-timeline-root-scroller.html:
Added.
* LayoutTests/webanimations/threaded-animations/threaded-animations-utils.js:
Added.
(const.animationAcceleration.async animation):
*
Source/WebKit/UIProcess/RemoteLayerTree/RemoteProgressBasedTimelineRegistry.cpp:
(WebKit::RemoteProgressBasedTimelineRegistry::hasTimelineForNode const):
(WebKit::RemoteProgressBasedTimelineRegistry::updateTimelinesForNode):
* Source/WebKit/UIProcess/RemoteLayerTree/RemoteProgressBasedTimelineRegistry.h:
* Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.h:
(WebKit::RemoteScrollingCoordinatorProxy::progressBasedTimelinesWereUpdatedForNode):
* Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingTree.cpp:
(WebKit::RemoteScrollingTree::hasTimelineForNode const):
(WebKit::RemoteScrollingTree::updateProgressBasedTimelinesForNode):
* Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingTree.h:
*
Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteScrollingCoordinatorProxyIOS.h:
*
Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteScrollingCoordinatorProxyIOS.mm:
(WebKit::RemoteScrollingCoordinatorProxyIOS::animationsWereAddedToNode):
(WebKit::RemoteScrollingCoordinatorProxyIOS::progressBasedTimelinesWereUpdatedForNode):
* Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteScrollingTreeIOS.cpp:
(WebKit::RemoteScrollingTreeIOS::scrollingTreeNodeDidScroll):
* Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteLayerTreeEventDispatcher.mm:
(WebKit::RemoteLayerTreeEventDispatcher::startOrStopDisplayLinkOnMainThread):
* Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteScrollingTreeMac.mm:
(WebKit::RemoteScrollingTreeMac::scrollingTreeNodeDidScroll):
Canonical link: https://commits.webkit.org/302702@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
