Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 83253d433aae47137c7e0cba6bae8b2b457abcf0
https://github.com/WebKit/WebKit/commit/83253d433aae47137c7e0cba6bae8b2b457abcf0
Author: Chris Dumez <[email protected]>
Date: 2025-11-06 (Thu, 06 Nov 2025)
Changed paths:
M
LayoutTests/http/tests/geolocation/geolocation-get-current-position-does-not-leak.https.html
M LayoutTests/http/tests/resources/document-leak-test.js
M LayoutTests/platform/ios/TestExpectations
Log Message:
-----------
[ iOS Release ]
http/tests/geolocation/geolocation-watch-position-does-not-leak.https.html is a
flakey text failure
https://bugs.webkit.org/show_bug.cgi?id=295992
rdar://155890249
Reviewed by Ryan Reno.
The issue was that the test would call `setInterval()` once per iframe
but would only cancel the setInterval for one frame in case of success.
As a result, setInterval could fire for other iframes after calling
finishJSTest() and log further text.
Address the issue by using a single setInterval for all the frames.
Address flakiness for the following tests that were flaky for the same reason:
-
http/tests/geolocation/geolocation-get-current-position-does-not-leak.https.html
- http/tests/canvas/ctx.2d-canvas-style-color-no-document-leak.html
- http/tests/canvas/ctx.2d-canvas-style-gradient-no-document-leak.html
- http/tests/canvas/ctx.2d-canvas-style-pattern-no-document-leak.html
- http/tests/webcodecs/audio-encoder-callbacks-do-not-leak.html
*
LayoutTests/http/tests/geolocation/geolocation-get-current-position-does-not-leak.https.html:
* LayoutTests/http/tests/resources/document-leak-test.js:
(createFrames):
(iframeLeaked): Deleted.
(iframeSentMessage): Deleted.
(runDocumentLeakTest): Deleted.
* LayoutTests/platform/ios/TestExpectations:
Canonical link: https://commits.webkit.org/302683@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
