Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 26fdd36cde06b4614dea7d8dbc47f4c8581168d9
https://github.com/WebKit/WebKit/commit/26fdd36cde06b4614dea7d8dbc47f4c8581168d9
Author: Geoffrey Garen <[email protected]>
Date: 2025-11-06 (Thu, 06 Nov 2025)
Changed paths:
M Source/WebGPU/WebGPU/CommandEncoder.mm
M Source/WebGPU/WebGPU/CommandEncoder.swift
M Source/WebGPU/WebGPU/QuerySet.h
M Source/WebGPU/WebGPU/QuerySet.mm
Log Message:
-----------
[WebGPU+Swift] Eliminate 'unsafe' caused by QuerySet.CounterSampleBuffer
https://bugs.webkit.org/show_bug.cgi?id=302055
rdar://164135057
Reviewed by Mike Wyrzykowski.
Swift treats std::pair<id, int> as unsafe because
(a) there's a pointer in there
(b) Swift has no way of knowing whether the pointer's lifetime is guaranteed or
not -- because Swift models C++ copy and move constructors and copy and move
assignment operators as opaque functions.
Switched from std::pair to a custom struct so I could declare it
SWIFT_ESCAPABLE.
I also took the opporutnity to give the data members more descriptive names than
'first' and 'second'.
Removed a Range(uncheckedBounds:) construction because it's unsafe and
we can use literal range syntax intead.
Changed some nil short-circuiting to use the ?? operator, for style.
Fixed up some stray ';', for style.
Canonical link: https://commits.webkit.org/302666@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
