Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 558951c36784bc87f02cd71fd1fdbcb2ee984ede
https://github.com/WebKit/WebKit/commit/558951c36784bc87f02cd71fd1fdbcb2ee984ede
Author: Jer Noble <[email protected]>
Date: 2025-11-04 (Tue, 04 Nov 2025)
Changed paths:
M Source/WebCore/SaferCPPExpectations/ForwardDeclCheckerExpectations
M Source/WebCore/css/parser/CSSParser.cpp
M Source/WebCore/css/parser/CSSParser.h
M Source/WebCore/svg/properties/SVGPropertyTraits.cpp
M Source/WebCore/svg/properties/SVGPropertyTraits.h
Log Message:
-----------
[Build Speed] REGRESSION(302163@main): Reduce includes of CSSParser.h
rdar://163815459
https://bugs.webkit.org/show_bug.cgi?id=301769
Reviewed by Brandon Stewart and Simon Fraser.
In 302163@main, an include of CSSParser.h was added to SVGPropertyTraits. Prior
to 302163@main, CSSParser.h was included 16 times, for a total CPU cost of
2.7s. After that revision, CSSParser.h was included 340 times, for a total CPU
cost of 4m11s.
Replace the includes of CSSParser.h, ColorSerialization.h, and StyleColor.h in
SVGPropertyTraits.h with forward declarations and move inline functions into
the implementation file. And remove the include of StyleColor.h with a forward
declaration.
After this patch, CSSParser.h dropped from the 9th most expensive header back
down to near where it started at 568th with a total CPU cost of about 3s.
* Source/WebCore/css/parser/CSSParser.cpp:
* Source/WebCore/css/parser/CSSParser.h:
* Source/WebCore/svg/properties/SVGPropertyTraits.cpp:
(WebCore::SVGPropertyTraits<Color>::parse):
(WebCore::SVGPropertyTraits<Color>::toString):
* Source/WebCore/svg/properties/SVGPropertyTraits.h:
(WebCore::SVGPropertyTraits<Color>::parse): Deleted.
(WebCore::SVGPropertyTraits<Color>::toString): Deleted.
Canonical link: https://commits.webkit.org/302550@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
