Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 02e22593fc4a8399e29375613632dea94bccbe81
https://github.com/WebKit/WebKit/commit/02e22593fc4a8399e29375613632dea94bccbe81
Author: Sam Weinig <[email protected]>
Date: 2025-11-02 (Sun, 02 Nov 2025)
Changed paths:
M Source/WebCore/SaferCPPExpectations/UncheckedCallArgsCheckerExpectations
M Source/WebCore/SaferCPPExpectations/UncheckedLocalVarsCheckerExpectations
M Source/WebCore/css/parser/CSSParser.cpp
M Source/WebCore/css/parser/CSSParser.h
M Source/WebCore/svg/SVGAnimateElementBase.cpp
M Source/WebCore/svg/SVGAnimateMotionElement.h
M Source/WebCore/svg/SVGClipPathElement.cpp
M Source/WebCore/svg/SVGComponentTransferFunctionElement.cpp
M Source/WebCore/svg/SVGComponentTransferFunctionElement.h
M Source/WebCore/svg/SVGFEBlendElement.h
M Source/WebCore/svg/SVGFEColorMatrixElement.cpp
M Source/WebCore/svg/SVGFEColorMatrixElement.h
M Source/WebCore/svg/SVGFECompositeElement.cpp
M Source/WebCore/svg/SVGFECompositeElement.h
M Source/WebCore/svg/SVGFEConvolveMatrixElement.cpp
M Source/WebCore/svg/SVGFEConvolveMatrixElement.h
M Source/WebCore/svg/SVGFEDisplacementMapElement.cpp
M Source/WebCore/svg/SVGFEDisplacementMapElement.h
M Source/WebCore/svg/SVGFEGaussianBlurElement.cpp
M Source/WebCore/svg/SVGFEMorphologyElement.cpp
M Source/WebCore/svg/SVGFEMorphologyElement.h
M Source/WebCore/svg/SVGFETurbulenceElement.cpp
M Source/WebCore/svg/SVGFETurbulenceElement.h
M Source/WebCore/svg/SVGFilterElement.cpp
M Source/WebCore/svg/SVGGradientElement.cpp
M Source/WebCore/svg/SVGGradientElement.h
M Source/WebCore/svg/SVGMarkerElement.cpp
M Source/WebCore/svg/SVGMarkerTypes.h
M Source/WebCore/svg/SVGMaskElement.cpp
M Source/WebCore/svg/SVGPatternElement.cpp
M Source/WebCore/svg/SVGSVGElement.cpp
M Source/WebCore/svg/SVGTextContentElement.cpp
M Source/WebCore/svg/SVGTextContentElement.h
M Source/WebCore/svg/SVGTextPathElement.cpp
M Source/WebCore/svg/SVGTextPathElement.h
M Source/WebCore/svg/SVGUnitTypes.h
M Source/WebCore/svg/SVGViewElement.cpp
M Source/WebCore/svg/SVGZoomAndPan.cpp
M Source/WebCore/svg/SVGZoomAndPan.h
M Source/WebCore/svg/SVGZoomAndPanType.h
M Source/WebCore/svg/properties/SVGAnimatedPropertyAnimator.h
M Source/WebCore/svg/properties/SVGAnimatedPropertyPairAnimatorImpl.h
M Source/WebCore/svg/properties/SVGAnimationAdditiveFunction.h
M Source/WebCore/svg/properties/SVGAnimationAdditiveListFunctionImpl.h
M Source/WebCore/svg/properties/SVGAnimationAdditiveValueFunctionImpl.cpp
M Source/WebCore/svg/properties/SVGAnimationAdditiveValueFunctionImpl.h
M Source/WebCore/svg/properties/SVGAnimationDiscreteFunction.h
M Source/WebCore/svg/properties/SVGAnimationDiscreteFunctionImpl.h
M Source/WebCore/svg/properties/SVGAnimationFunction.h
M Source/WebCore/svg/properties/SVGAttributeAnimator.h
M Source/WebCore/svg/properties/SVGPrimitivePropertyAnimator.h
M Source/WebCore/svg/properties/SVGPropertyAnimator.h
M Source/WebCore/svg/properties/SVGPropertyTraits.cpp
M Source/WebCore/svg/properties/SVGPropertyTraits.h
Log Message:
-----------
Pass a color parsing context to parser when parsing colors in SVG
https://bugs.webkit.org/show_bug.cgi?id=301808
Reviewed by Anne van Kesteren.
Unifies all the color parsing done by SVG animation code
to use a single entry point, SVGPropertyTraits<Color>::fromString.
To make this work, all SVGPropertyTraits<*>::fromString functions
now have a `SVGElement&` first parameter. To make that work, a bit
of plumbing was required.
The implementation of SVGPropertyTraits<*>::fromString is modeled
on the `parseColor` function in CanvasStyle.cpp. If more of these
explicit `CSS::PlatformColorResolutionDelegate` implementations
are needed, some additional sharing can be done.
This allows us to remove `CSSParser::parseColorOrCurrentColorWithoutContext`
and a few uses of
`CSSPropertyParserHelpers::deprecatedParseColorRawWithoutContext`
leaving only three remaining (ApplicationManifestParser, HTMLMetaElement,
and StyleProperties).
* Source/WebCore/css/parser/CSSParser.cpp:
* Source/WebCore/css/parser/CSSParser.h:
* Source/WebCore/svg/SVGAnimateElementBase.cpp:
* Source/WebCore/svg/SVGAnimateMotionElement.h:
* Source/WebCore/svg/SVGClipPathElement.cpp:
* Source/WebCore/svg/SVGComponentTransferFunctionElement.cpp:
* Source/WebCore/svg/SVGComponentTransferFunctionElement.h:
* Source/WebCore/svg/SVGFEBlendElement.h:
* Source/WebCore/svg/SVGFEColorMatrixElement.cpp:
* Source/WebCore/svg/SVGFEColorMatrixElement.h:
* Source/WebCore/svg/SVGFECompositeElement.cpp:
* Source/WebCore/svg/SVGFECompositeElement.h:
* Source/WebCore/svg/SVGFEConvolveMatrixElement.cpp:
* Source/WebCore/svg/SVGFEConvolveMatrixElement.h:
* Source/WebCore/svg/SVGFEDisplacementMapElement.cpp:
* Source/WebCore/svg/SVGFEDisplacementMapElement.h:
* Source/WebCore/svg/SVGFEGaussianBlurElement.cpp:
* Source/WebCore/svg/SVGFEMorphologyElement.cpp:
* Source/WebCore/svg/SVGFEMorphologyElement.h:
* Source/WebCore/svg/SVGFETurbulenceElement.cpp:
* Source/WebCore/svg/SVGFETurbulenceElement.h:
* Source/WebCore/svg/SVGFilterElement.cpp:
* Source/WebCore/svg/SVGGradientElement.cpp:
* Source/WebCore/svg/SVGGradientElement.h:
* Source/WebCore/svg/SVGMarkerElement.cpp:
* Source/WebCore/svg/SVGMarkerTypes.h:
* Source/WebCore/svg/SVGMaskElement.cpp:
* Source/WebCore/svg/SVGPatternElement.cpp:
* Source/WebCore/svg/SVGSVGElement.cpp:
* Source/WebCore/svg/SVGTextContentElement.cpp:
* Source/WebCore/svg/SVGTextContentElement.h:
* Source/WebCore/svg/SVGTextPathElement.cpp:
* Source/WebCore/svg/SVGTextPathElement.h:
* Source/WebCore/svg/SVGUnitTypes.h:
* Source/WebCore/svg/SVGViewElement.cpp:
* Source/WebCore/svg/SVGZoomAndPan.cpp:
* Source/WebCore/svg/SVGZoomAndPan.h:
* Source/WebCore/svg/SVGZoomAndPanType.h:
* Source/WebCore/svg/properties/SVGAnimatedPropertyAnimator.h:
* Source/WebCore/svg/properties/SVGAnimatedPropertyPairAnimatorImpl.h:
* Source/WebCore/svg/properties/SVGAnimationAdditiveFunction.h:
* Source/WebCore/svg/properties/SVGAnimationAdditiveListFunctionImpl.h:
* Source/WebCore/svg/properties/SVGAnimationAdditiveValueFunctionImpl.cpp:
* Source/WebCore/svg/properties/SVGAnimationAdditiveValueFunctionImpl.h:
* Source/WebCore/svg/properties/SVGAnimationDiscreteFunction.h:
* Source/WebCore/svg/properties/SVGAnimationDiscreteFunctionImpl.h:
* Source/WebCore/svg/properties/SVGAnimationFunction.h:
* Source/WebCore/svg/properties/SVGAttributeAnimator.h:
* Source/WebCore/svg/properties/SVGPrimitivePropertyAnimator.h:
* Source/WebCore/svg/properties/SVGPropertyAnimator.h:
* Source/WebCore/svg/properties/SVGPropertyTraits.cpp:
* Source/WebCore/svg/properties/SVGPropertyTraits.h:
Canonical link: https://commits.webkit.org/302455@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
