On Thu, 14 Mar 2019 16:01:08 +0530 Harish Krupo <[email protected]> wrote:
> Hi, > > I have written a clang format file based on this example [1], to > match the coding style here [2]. Does the below config look okay or > should something be changed? > If people are interested, I can open a MR for this. This could also be > used in the CI to warn/abort if a patch isn't according to the coding > style. > > The config: > BasedOnStyle: LLVM > IndentWidth: 8 > TabWidth: 8 > UseTab: Always > BreakBeforeBraces: Linux > AllowShortIfStatementsOnASingleLine: false > IndentCaseLabels: false > AlwaysBreakAfterReturnType: TopLevel > > [1] https://clang.llvm.org/docs/ClangFormatStyleOptions.html#examples > [2] > https://gitlab.freedesktop.org/wayland/weston/blob/master/CONTRIBUTING.md#coding-style Hi Harish, I guess that depends on how different that is from the existing code base style. Seeing the warning list generated for the existing code would tell a lot, I doubt it would be empty. Is the LLVM style something guaranteed to not change? Using it in CI might be an attractive idea, but I wonder if it would result in many false warnings. Some aspects of coding style are always somewhat vague and need to adapt to the code at hand to look nice to a human rather than follow some rigorous rules. If it leaves such things as is and checks only those that should follow rigorous rules, that would be nice. Obviously I'm not familiar the Clang formatting features. Thanks, pq
pgp6DAZ3CYNjZ.pgp
Description: OpenPGP digital signature
_______________________________________________ wayland-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/wayland-devel
