On Thu, Jan 24, 2019 at 12:53:28PM +0200, Pekka Paalanen wrote: > Hi, > > you need to split this into logical patches, each patch doing one > logical thing. It is not the same as one patch per file. Each patch > needs to have a commit message explaining why the patch was written, > and so on. Please, see > https://gitlab.freedesktop.org/wayland/wayland/blob/master/CONTRIBUTING.md >
Ok. > As for merging, I think I saw some bits that don't actually need any > #ifdef BSD guards but would be good fixes regardless of the OS. Patches > that do not depend on a specific OS I think we can land without having > a BSD in CI, but patches that depend on being built on a BSD should > come with CI. I won't personally have the time to figure out how to run > a BSD in Gitlab CI, someone else needs to write the patch. > > It would also be good to instead of hardcoding things like > #if Dragonfly /* no mremap */ to have autoconf test for the existence of > mremap, since the fallback to munmap+mmap seems quite generic. > Ok, I'll resend after Gitlab CI will be set up. Meanwhile I'll make sure this patch gets to Ravenports: https://github.com/mazocomp/openbsd-wip/blob/master/graphics/wayland/patches/patch-src_wayland-shm_c#L43 > > Thanks, > pq _______________________________________________ wayland-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/wayland-devel
