On Tue, 22 Jan 2019 15:42:17 +1300 Christopher James Halse Rogers <r...@ubuntu.com> wrote:
> On 20 November 2018 8:02:50 pm NZDT, Christopher James Halse Rogers > <christopher.halse.rog...@canonical.com> wrote: > >Many languages such as C++ or Rust have an unwinding error-reporting > >mechanism. Code in these languages can (and must!) wrap request > >handling > >callbacks in unwind guards to avoid undefined behaviour. > > > >As a consequence such code will detect internal server errors, but have > >no way to communicate such failures to the client. > > > >This adds a WL_DISPLAY_ERROR_IMPLEMENTATION error to wl_display so that > >such code can notify (and disconnect) clients which hit internal bugs. > >While servers can currently abuse other wl_display errors for the same > >effect, adding an explicit error code allows clients to tell the > >difference between errors which are their fault and errors which are > >the > >server's fault. This is particularly interesting for automated bug > >reporting. > > > >v2: Rename error from "internal" to "implementation", in sympathy with > > X11's BadImplementation error. > > Add more justification in the commit message. > > > >Signed-off-by: Christopher James Halse Rogers > ><christopher.halse.rog...@canonical.com> > >Acked-by: Pekka Paalanen <pekka.paala...@collabora.co.uk> > >--- > > protocol/wayland.xml | 2 ++ > > src/wayland-client.c | 3 +++ > > src/wayland-server-core.h | 4 ++++ > > src/wayland-server.c | 24 +++++++++++++++++++++++ > > tests/display-test.c | 40 +++++++++++++++++++++++++++++++++++++++ > > 5 files changed, 73 insertions(+) > Ping! > > Is there anything I can do to make these patches more appealing? Hi raof, not for me, I just need the time to get there. :-) Thanks, pq
pgp857lrq862I.pgp
Description: OpenPGP digital signature
_______________________________________________ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel
